feat(web): Generic exception handling #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajordens
force-pushed
the
better-exception-handling
branch
from
2858642 to
3e00378
Compare
|
An attempt at cleaning up how exceptions are propagated out of a service. If this approach seems reasonable, I would pull a few bits up to |
ajordens
commented
Jul 11, 2017
|
|
||
| @ExceptionHandler(Exception.class) | ||
| void handleException(Exception e, HttpServletResponse response, HttpServletRequest request) throws IOException { | ||
| logger.error("Internal Server Error", e); |
There was a problem hiding this comment.
Ensures we get a log message for otherwise unhandled exceptions (by default an exception w/ a Handler does not log).
ajordens
commented
Jul 11, 2017
| throw new ProjectNotFoundException("Project not found (projectId: ${projectId})") | ||
| } | ||
| result | ||
| return projectService.get(projectId) |
There was a problem hiding this comment.
The previous bits were bogus anyways ... you'll never get a null value back (rather a RetrofitError).
robzienert
reviewed
Jul 11, 2017
|
|
||
| @Override | ||
| public Map<String, Object> getAdditionalAttributes() { | ||
| return Collections.singletonMap("my-attribute", "my-value"); |
There was a problem hiding this comment.
Is this intended to stick around?
There was a problem hiding this comment.
Good catch ... this was a crazy test.
|
I like it! |
cfieber
approved these changes
Jul 11, 2017
|
|
||
| @Override | ||
| public Map<String, Object> getAdditionalAttributes() { | ||
| return Collections.singletonMap("my-attribute", "my-value"); |
There was a problem hiding this comment.
I don't think this is the correct additionalAttributes?
robzienert
approved these changes
Jul 11, 2017
Introduces a single NotFoundException that can be used in place of all
previous *NotFoundException classes (ie. ApplicationNotFoundException,
SecurityGroupNotFoundException, etc).
The default ErrorController has been replaced with one that will always
return application/json.
A stacktrace will be included if ?trace=true is appended to the request.
Example error response:
```
{
"error": "Not Found",
"exception": "com.netflix.spinnaker.gate.exceptions.NotFoundException",
"message": "Application not found (id: some_application_name)",
"status": 404,
"timestamp": 1499731805410
}
```
ajordens
force-pushed
the
better-exception-handling
branch
from
3e00378 to
8135d5a
Compare
|
The errant I'll refactor out to |
ajordens
added a commit
to ajordens/kork
that referenced
this pull request
Jul 11, 2017
ajordens
added a commit
to ajordens/kork
that referenced
this pull request
Jul 11, 2017
ajordens
added a commit
to spinnaker/kork
that referenced
this pull request
Jul 11, 2017
danielpeach
pushed a commit
to danielpeach/gate
that referenced
this pull request
May 24, 2018
Introduces a single NotFoundException that can be used in place of all
previous *NotFoundException classes (ie. ApplicationNotFoundException,
SecurityGroupNotFoundException, etc).
The default ErrorController has been replaced with one that will always
return application/json.
A stacktrace will be included if ?trace=true is appended to the request.
Example error response:
```
{
"error": "Not Found",
"exception": "com.netflix.spinnaker.gate.exceptions.NotFoundException",
"message": "Application not found (id: some_application_name)",
"status": 404,
"timestamp": 1499731805410
}
```
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a single NotFoundException that can be used in place of all
previous *NotFoundException classes (ie. ApplicationNotFoundException,
SecurityGroupNotFoundException, etc).
The default ErrorController has been replaced with one that will always
return application/json.
A stacktrace will be included if ?trace=true is appended to the request.
Example error response: