fix(oauth): Fix issue where externally-terminated SSL deployments had… #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… HTTP-only redirect to /login
|
@ttomsu confirmed that it works! Thank you so much! |
|
There's still a little inconsistent behavior that I didn't see when testing this. After the This solves the problem it is supposed to but exposes another problem. If you refresh the page, you are in fact authenticated. |
danielpeach
pushed a commit
to danielpeach/gate
that referenced
this pull request
May 24, 2018
… HTTP-only redirect to /login (spinnaker#390)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… HTTP-only redirect to /login
@ethanfrogers, please give this guy a spin.
@cfieber FYI, but this PR shouldn't affect you.