Makes anonymous principal's allowedAccounts updated periodically #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .principal(principal) | ||
| .and() | ||
| .csrf().disable() | ||
| .csrf() |
| @Scheduled(initialDelay = 30000L, fixedDelay = 60000L) | ||
| void updateAnonymousAccounts() { | ||
| def newAnonAccounts = accountsService.getAllowedAccounts([]) | ||
| anonymousAllowedAccounts.clear() |
There was a problem hiding this comment.
Would rather do this without the window where the list is empty.
|
LGTM after addressing comment. |
| @Autowired | ||
| AccountsService accountsService | ||
|
|
||
| List<String> anonymousAllowedAccounts = [] |
There was a problem hiding this comment.
I'd make this a concurrent collection (CopyOnWriteArrayList?) since it is getting mutated in a background thread
|
just the one comment otherwise LGTM |
|
LGTM, NARB |
Closed
Closed
kirangodishala
pushed a commit
to kirangodishala/gate
that referenced
this pull request
May 23, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ajordens @cfieber @jtk54 @duftler PTAL
Tests won't pass until spinnaker/kork#40 is merged and released.