Merged AccountService into CredentialsService #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,7 @@ | |||
| #!/bin/bash | |||
|
LOTM. Not sure if someone else wants to have a look too. |
ttomsu
force-pushed
the
google-merged-services
branch
from
7d8f345 to
825c0f6
Compare
| @Autowired | ||
| CredentialsService credentialsService | ||
|
|
||
| List<String> anonymousAllowedAccounts = [] |
There was a problem hiding this comment.
It will get pulled in once this PR has been rebased on the other one.
|
LGTM after merge with upstream. |
| .disable() | ||
| } | ||
|
|
||
| @Scheduled(initialDelay = 30000L, fixedDelay = 60000L) |
There was a problem hiding this comment.
Anything bad happen to the scheduler if an exception is raised? Might want to wrap in a try/catch.
There was a problem hiding this comment.
Done. Also removed initial delay - it isn't necessary if clouddriver is already up.
Edit: Made the change in the other PR, where this block was introduced.
ttomsu
force-pushed
the
google-merged-services
branch
from
825c0f6 to
12707d4
Compare
danielpeach
pushed a commit
to danielpeach/gate
that referenced
this pull request
May 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getAccountswill now return all anonymous accounts. A new, overloaded method is introduced to get all anonymous accounts + all accounts the user has access to if the method is provided with the user's roles.Based on #241 to be merged first. Review second commit only. Tests won't pass until spinnaker/kork#40 is merged and released.
@ajordens @cfieber @jtk54 @duftler PTAL