Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable X509 authentication #198

Merged
merged 1 commit into from
Apr 29, 2016

Conversation

ttomsu
Copy link
Member

@ttomsu ttomsu commented Apr 28, 2016

@jtk54 @rwinch PTAL.

I haven't looked, but hopefully Boot 1.3 adds in the ability to override a few hard coded classes in the http.x509 configurer.

@@ -18,6 +18,7 @@ package com.netflix.spinnaker.gate.controllers

import com.netflix.spinnaker.gate.security.SpinnakerUser
import com.netflix.spinnaker.security.User
import org.springframework.security.core.context.SecurityContextHolder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused import?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@ttomsu ttomsu force-pushed the google-oauth-x509 branch from cccccc4 to 711d0f8 Compare April 28, 2016 20:37
@jtk54
Copy link
Contributor

jtk54 commented Apr 28, 2016

LGTM.

@ttomsu ttomsu merged commit 02b0769 into spinnaker:google-oauth Apr 29, 2016
@ttomsu ttomsu deleted the google-oauth-x509 branch April 29, 2016 12:23
ttomsu pushed a commit to ttomsu/gate that referenced this pull request May 2, 2016
ttomsu pushed a commit that referenced this pull request May 2, 2016
ttomsu pushed a commit to ttomsu/gate that referenced this pull request May 6, 2016
@spinnakerbot spinnakerbot mentioned this pull request Oct 12, 2022
@spinnakerbot spinnakerbot mentioned this pull request Nov 16, 2022
kirangodishala pushed a commit to kirangodishala/gate that referenced this pull request May 23, 2023
@spinnakerbot spinnakerbot mentioned this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants