segment hystrix command keys by cloud provider #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| private final ClouddriverService clouddriverService | ||
|
|
||
| private final LoadingCache<String, List<ClouddriverService.Account>> accountsCache = CacheBuilder.newBuilder() |
There was a problem hiding this comment.
This is just to debounce calls to translate account name -> provider name so every hystrix command key generation doesn't result in another remote call
|
LGTM |
Closed
Closed
kirangodishala
pushed a commit
to kirangodishala/gate
that referenced
this pull request
May 23, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
though most of these are read operations, in the event of bad data or a bug in one cloud provider, we shouldn't circuit break across others
@spinnaker/netflix-reviewers PTAL