Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

At make-source step, there are no SPK environment variables #25

Closed
lgritz opened this issue Apr 27, 2021 · 1 comment · Fixed by #72
Closed

At make-source step, there are no SPK environment variables #25

lgritz opened this issue Apr 27, 2021 · 1 comment · Fixed by #72
Labels
enhancement New feature or request

Comments

@lgritz
Copy link
Contributor

lgritz commented Apr 27, 2021

If you try to use

sources:
    - script
        - env
        - ...

to customize how the source area is copied to an spk layer, you quickly find (via that env) that there are no SPK_* or other environment variables set, no breadcrumbs that let you write interesting scripts that know what they are doing. In particular, I cannot figure out how one can detect what was the pwd when spk build was run, that is, the place where you are supposed to be copying from.

I think it would be good if at the "sources" stage, we had available all of the same SPK env variables that are present at the "build" stage. At the very least, the project name, the version, and the launch directory are a bare minimum. But the whole works would be better, including other build variables/options, versions of dependencies, etc.

@lgritz lgritz added enhancement New feature or request spk labels Apr 27, 2021
@lgritz
Copy link
Contributor Author

lgritz commented May 3, 2021

HELP WANTED on this one. I know that not all SPK env variables can be ready (some values change for each variant, obviously). But there is some minimum set -- the name and version of the package being built, the path to the original source area from which things should be copied, etc. -- that could be known and would be very helpful to writing sources script.

@rydrman rydrman changed the title At build step, there are no SPK environment variables At make-source step, there are no SPK environment variables May 11, 2021
rydrman added a commit that referenced this issue Aug 6, 2022
jrray pushed a commit that referenced this issue Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant