Update sources process to set build environment #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation relies on modifying os.environ directly which is not amazing but adding an env parameter to the collection contract seemed like overkill when only the one type of sources would actually make use of the values. If we get to a templted system in the future maybe this is something that we can reconsider Signed-off-by: Ryan Bottriell <ryan@bottriell.ca>
|
Yay! |
jrray
added a commit
that referenced
this pull request
Jul 19, 2023
Fix cyclic crate dependency #1 ########72 characters################################################## Move the macros in spk-solve to its own crate, to break the cycle of spk-solve -> spk-solve-validation -> spk-solve (dev) The macro code was changed to remove many uses of re-exported symbols through `$crate`, since adding these dependencies would reintroduce a cyclic dependency. Signed-off-by: J Robert Ray <jrray@jrray.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation relies on modifying os.environ directly which
is not amazing but adding an env parameter to the collection
contract seemed like overkill when only the one type of sources
would actually make use of the values. If we get to a templted
system in the future maybe this is something that we can reconsider
Signed-off-by: Ryan Bottriell ryan@bottriell.ca
@lgritz @DiegoTavares @dansheerin @jrray
Closes #25