Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pip conversion should not encourage republishing of existing packages #50

Open
DiegoTavares opened this issue May 5, 2021 · 0 comments
Open

Pip conversion should not encourage republishing of existing packages #50

DiegoTavares opened this issue May 5, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@DiegoTavares
Copy link

DiegoTavares commented May 5, 2021 •
edited
Loading

Converting from pip is an easy way to bring in python deps, but republishing over existing packages is dangerous, especially as pip changes over time and we upgrade automatic package conversions into manually built ones (like pyyaml)

Ideally, when confirming the publishing of converted packages, the command should separate into groups of existing and new packages - only publishing the new packages by default - republishing existing ones only if given some other answer or provided an extra flag

(By @rydrman )
@DiegoTavares DiegoTavares added enhancement New feature or request good first issue Good for newcomers labels May 5, 2021
rydrman added a commit that referenced this issue Aug 6, 2022
@rydrman
Merge pull request #50 from imageworks/grpc-server
04beae3 
Initial gRPC Server Implementation
jrray pushed a commit that referenced this issue Aug 11, 2022
@rydrman
Merge pull request #50 from imageworks/grpc-server
0aef59e 
Initial gRPC Server Implementation
jrray added a commit that referenced this issue Jul 19, 2023
@jrray
########50 characters############################
651da07 
Fix cyclic crate dependency #1

########72 characters##################################################
Move the macros in spk-solve to its own crate, to break the cycle of

   spk-solve -> spk-solve-validation -> spk-solve (dev)

The macro code was changed to remove many uses of re-exported symbols
through `$crate`, since adding these dependencies would reintroduce a
cyclic dependency.

Signed-off-by: J Robert Ray <jrray@jrray.org>
jrray added a commit that referenced this issue Jul 19, 2023
@jrray
########50 characters############################
5df3367 
Fix cyclic crate dependency #2

########72 characters##################################################
Relocate a tests file to avoid a cyclic dependency:

    spk_schema -> spk_schema_validators -> spk_schema (dev)

Signed-off-by: J Robert Ray <jrray@jrray.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DiegoTavares