Add useful diff representation of Time-like values #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should add a more useful diff for Time instances, as well as make the diff output from ActiveSupport::TimeWithZone instances readable. Previously the ActiveSupport::TimeWithZone diff output would contain all the timezones, leading to several thousand lines in the diff. Now all time-like instances will work the same way: Single-line diffs will be of a simple ISO-like string, while the full diff will show which parts of the time actually differs. Timezone is promptly shown, both with name and with GMT offset.
This should help some people even more quickly see why the two dates are different moments in time as they won't have to do the offset calculation in their heads when they see the difference in hours/minutes and gmt_offset.
|
I added an additional commit that shows a normalized timestamp (in UTC) in the diff if the two dates have different timezones set.
I hope this would help people that struggle with timezones. Let me know what you think about that one. |
|
Hey, sorry for the delay in responding, I just switched over to the new notifications so I guess this one slipped through. Thanks so much for fixing this — looks like you figured out how things work :) Your PR description was really easy to follow and your implementation looks great too! I think this will be really useful. |
|
Thanks a lot! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should add a more useful diff for
Timeinstances, as well as make the diff output fromActiveSupport::TimeWithZoneinstances readable.Previously the
ActiveSupport::TimeWithZonediff output would contain all the timezones, leading to several thousand lines in the diff. Now all time-like instances will work the same way: Single-line diffs will be of a simple ISO-like string, while the full diff will show which parts of the time actually differs.Timezone is promptly shown, both with name and with GMT offset.
This should fix #52.
Screenshots
Before
TimevsTimeTimevsActiveSupport::TimeWithZoneAfter
TimevsTimeTimevsActiveSupport::TimeWithZone