Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add useful diff representation of Time-like values #61

Merged
merged 2 commits into from
Nov 26, 2019
Merged

Add useful diff representation of Time-like values #61

merged 2 commits into from
Nov 26, 2019

Commits on Nov 20, 2019

  1. Add useful diff representation of Time-like values 

    This should add a more useful diff for Time instances, as well as make
the diff output from ActiveSupport::TimeWithZone instances readable.

Previously the ActiveSupport::TimeWithZone diff output would contain all
the timezones, leading to several thousand lines in the diff. Now all
time-like instances will work the same way: Single-line diffs will be of
a simple ISO-like string, while the full diff will show which parts of
the time actually differs.

Timezone is promptly shown, both with name and with GMT offset.
    @Mange
    Mange committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    d13dc2a View commit details
    Browse the repository at this point in the history

  2. Show UTC timestamp in Time diffs when zone differs 

    This should help some people even more quickly see why the two dates are
different moments in time as they won't have to do the offset
calculation in their heads when they see the difference in hours/minutes
and gmt_offset.
    @Mange
    Mange committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    066ed1f View commit details
    Browse the repository at this point in the history