Add a dash of modernity #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pbyrne
commented
Apr 9, 2019
pbyrne
commented
- Permit to run with (API-compatible) AWS SDK v3
- Update Travis build matrix to modern versions of Ruby
pbyrne
commented
Apr 9, 2019
| @@ -18,7 +18,7 @@ Gem::Specification.new do |spec| | |||
| spec.test_files = Dir['spec/**/*'] | |||
| spec.require_paths = ["lib"] | |||
|
|
|||
| spec.add_dependency "aws-sdk", "~> 2" | |||
| spec.add_dependency "aws-sdk", ">= 2.0", "< 4.0" | |||
There was a problem hiding this comment.
Per the AWS upgrade docs, no code changes should be necessary. It'd be great, in a post-v2 world to tweak the dependencies to load just the pieces we need (aws-sdk-s3, aws-sdk-ec2, aws-sdk-opsworks, aws-sdk-iam I think covers it), but I don't think we can do that with v2 still in the mix. As-is, we continue to load the whole universe of AWS SDK code, which leaves us no worse off than with v2 (which was the only option available to us until they broke the pieces apart with v3).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.