Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a dash of modernity #158

Merged
merged 3 commits into from
Apr 9, 2019
Merged

Add a dash of modernity #158

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
522a6d4
Permit AWS SDK 3.x, an API-compatible upgrade
pbyrne Apr 9, 2019
5a91bbe
Update build matrix to active versions of Ruby
pbyrne Apr 9, 2019
0ac4c05
Fix build errors on Travis
pbyrne Apr 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 4 additions & 5 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
language: ruby
sudo: false
rvm:
- 2.0.0-p648
- 2.1.10
- 2.2.6
- 2.3.1
- 2.4.0
- 2.3.8
- 2.4.6
- 2.5.5
- 2.6.1
script: bundle exec rspec
2 changes: 1 addition & 1 deletion opsicle.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Gem::Specification.new do |spec|
spec.test_files = Dir['spec/**/*']
spec.require_paths = ["lib"]

spec.add_dependency "aws-sdk", "~> 2"
spec.add_dependency "aws-sdk", ">= 2.0", "< 4.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the AWS upgrade docs, no code changes should be necessary. It'd be great, in a post-v2 world to tweak the dependencies to load just the pieces we need (aws-sdk-s3, aws-sdk-ec2, aws-sdk-opsworks, aws-sdk-iam I think covers it), but I don't think we can do that with v2 still in the mix. As-is, we continue to load the whole universe of AWS SDK code, which leaves us no worse off than with v2 (which was the only option available to us until they broke the pieces apart with v3).

spec.add_dependency "gli", "~> 2.9"
spec.add_dependency "highline", "~> 1.6"
spec.add_dependency "terminal-table", "~> 1.4"
Expand Down