Global ctx passed into the provider via FeatureProvider #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziodemaria
commented
May 19, 2023
| val parsedKey = FlagKey(key) | ||
| val evaluationContext = currEvaluationContext ?: throw ProviderNotReadyError() | ||
| val evaluationContext = context ?: throw InvalidContextError() |
There was a problem hiding this comment.
A missing context here means that no global context has been set in the global SDK, but a context is required in our Provider. It's not the Provider that is not ready, but the Context from the SDK that is invalid/missing.
fabriziodemaria
commented
May 19, 2023
| override suspend fun initialize(initialContext: EvaluationContext?) { | ||
| currEvaluationContext = initialContext |
There was a problem hiding this comment.
The initialContext is still passed via inizitialize for the Provider to be able to warm up the cache. Subsequent evaluations will use the global context defined in the SDK, and if the cached-context is different than the evaluation-context, the evaluation will fail with reason STALE
fabriziodemaria
force-pushed
the
ctx-passed-in
branch
from
713dc0d
to
a848d77
Compare
nicklasl
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for SDK change: spotify/openfeature-kotlin-sdk#7