This repository has been archived by the owner on Sep 13, 2023. It is now read-only.
Global ctx passed into the provider via FeatureProvider #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziodemaria
commented
May 19, 2023
| @@ -165,13 +165,14 @@ class OpenFeatureClient( | |||
| var details = FlagEvaluationDetails(key, defaultValue) | |||
| val provider = openFeatureAPI.getProvider() ?: NoOpProvider() | |||
| val mergedHooks: List<Hook<*>> = provider.hooks + options.hooks + hooks + openFeatureAPI.hooks | |||
| val context = openFeatureAPI.getEvaluationContext() ?: MutableContext() | |||
There was a problem hiding this comment.
Sending an optional context to the Provider allows the Provider to be able to distinguish a valid empty context from a missing context, and change the evaluation behaviour accordingly
nicklasl
approved these changes
May 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More context about this change here: open-feature/ofep#41 (comment) (with the related specification now merged in
mainat the end of this section)Within a single evaluation, the SDK now propagates the same Context data all the way to the Provider. This ensures that the same Context data is used in the Hooks and in the Provider's Evaluation, preventing possible race conditions caused by the single global Context being read multiple times within the same evaluation