feat: Create organisation client to access teams endpoints #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
============================================
+ Coverage 73.77% 74.23% +0.46%
- Complexity 256 263 +7
============================================
Files 40 41 +1
Lines 896 920 +24
Branches 41 41
============================================
+ Hits 661 683 +22
- Misses 210 212 +2
Partials 25 25
|
Abhi347
previously approved these changes
Jul 5, 2023
dziemba
reviewed
Jul 5, 2023
dziemba
reviewed
Jul 5, 2023
| Optional<String> description(); | ||
|
|
||
| /** | ||
| * List GitHub IDs for organization members who will |
There was a problem hiding this comment.
IDs is a bit confusing to me. Are these usernames?
There was a problem hiding this comment.
The GitHub ID is the unique integer associated with a user. Which is unfortunately poorly documented :/
I used the documentation for the GitHub API to describe the params here:
https://docs.github.com/en/rest/teams/teams?apiVersion=2022-11-28#create-a-team
There was a problem hiding this comment.
Makes sense, then let's leave it as-is 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR adds an organisation client that exposes the following Teams API endpoints:
What happens next:
This functionality will be extended to expose the memberships endpoints so that team members within a team can be updated/created/deleted.
Tests:
Unit tests have been created for all the above mentioned endpoints.
Fixtures were created using the expected request and response bodies as detailed in the Github Teams API documentation here: https://docs.github.com/en/rest/teams/teams?apiVersion=2022-11-28