feat: add membership APIs to manage team members #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
============================================
+ Coverage 74.23% 74.94% +0.70%
- Complexity 263 272 +9
============================================
Files 41 42 +1
Lines 920 946 +26
Branches 41 41
============================================
+ Hits 683 709 +26
Misses 212 212
Partials 25 25
|
dziemba
approved these changes
Jul 13, 2023
Abhi347
reviewed
Jul 13, 2023
Comment on lines
+53
to
+54
| public TeamClient createTeamClient(final GitHubClient github, final String org) { | ||
| return TeamClient.create(github, org); |
There was a problem hiding this comment.
This looks like a breaking change from the earlier version 🤔
There was a problem hiding this comment.
I had the same thought, but I think it's fine since we just released the code that we're breaking here last week (#135), therefore nobody is using it yet probably.
There was a problem hiding this comment.
Good point that hopefully no one is using it. Can we also unpublish the earlier version somehow? In case someone decide to use it in future?
Other than that I agree it's not worth the effort to fix the breakage.
Abhi347
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
The organisation client has been refactored to better mirror the GitHub API and also match the existing pattern of nested APIs across the client. There is now a Teams Client that is nested under the organisation client which exposes the existing Teams APIs and adds the additional Membership endpoints below:
What happens next:
This refactor allows organisation related endpoints to be attached directly to the organisation client whilst keeping the Teams/Memberships endpoints separated.
Tests:
Unit tests have been created for all the above mentioned endpoints.
Fixtures were created using the expected request and response bodies as detailed in the Github Memberships API documentation here: https://docs.github.com/en/rest/teams/members?apiVersion=2022-11-28