[Chore] bump d3 to 5.9.x #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekh64
commented
Jul 8, 2019
| @@ -117,7 +117,7 @@ export default class FunnelChart extends React.Component { | |||
| .y1((d, i) => yScale(getValue(y, d, i))); | |||
| } | |||
|
|
|||
| const colors = scaleOrdinal(schemeCategory20b).domain(_.range(10)); | |||
| const colors = scaleOrdinal(schemeCategory10).domain(_.range(10)); | |||
There was a problem hiding this comment.
here is where I needed to change the color scale
There was a problem hiding this comment.
Hey @ekh64. This is great! Thanks for doing this.
Looks like you committed the build as well. A quick npm run clean should remove the built files for you. Will do some QA myself and get back to you on the rest of the PR.
|
@krissalvador27 thanks for this, I thought I needed to commit the build files 😳 Maybe they can be built into a directory that's |
krissalvador27
approved these changes
Jul 9, 2019
install
pushed a commit
that referenced
this pull request
Feb 25, 2020
* bump d3 to 5.9.x * exterminate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #154
d3to5.9.74.xto5.xschemeCategory20bin favor ofschemeCategory10inFunnelChartd3-sankeyto0.12.1All tests pass