Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] bump d3 to 5.9.x #155

Merged
merged 2 commits into from
Jul 9, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 0 additions & 90 deletions docs/build/bundle.689d071b087437dc7728.js

This file was deleted.

90 changes: 90 additions & 0 deletions docs/build/bundle.e7b56a53910b749af724.js

Large diffs are not rendered by default.

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/build/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,5 @@
</div>

<div class="container-fluid" id="container">Loading...</div>
<script type="text/javascript" src="bundle.689d071b087437dc7728.js"></script></body>
<script type="text/javascript" src="bundle.e7b56a53910b749af724.js"></script></body>
</html>
293 changes: 148 additions & 145 deletions package-lock.json

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@
"test-watch": "env NODE_PATH=$NODE_PATH:$PWD/src BABEL_ENV=production mocha --watch --compilers js:@babel/register --require tests/jsdom/setup.js --recursive tests/jsdom/spec"
},
"dependencies": {
"d3": "^4.4.0",
"d3-sankey": "^0.7.1",
"d3": "^5.9.7",
"d3-sankey": "^0.12.1",
"invariant": "^2.2.0",
"lodash": "^4.17.11",
"moment": "^2.10.6",
Expand Down
4 changes: 2 additions & 2 deletions src/FunnelChart.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { area, scaleOrdinal, schemeCategory20b } from "d3";
import { area, scaleOrdinal, schemeCategory10 } from "d3";
import _ from "lodash";
import PropTypes from "prop-types";
import React from "react";
Expand Down Expand Up @@ -117,7 +117,7 @@ export default class FunnelChart extends React.Component {
.y1((d, i) => yScale(getValue(y, d, i)));
}

const colors = scaleOrdinal(schemeCategory20b).domain(_.range(10));
const colors = scaleOrdinal(schemeCategory10).domain(_.range(10));
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here is where I needed to change the color scale


return (
<g className="rct-funnel-chart">
Expand Down