add alignment prop for domain start and end label to keep within chart footprint #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 8, 2020 16:54
acmei
approved these changes
Jul 9, 2020
acmei
approved these changes
Jul 9, 2020
| * overhang where the first and possibly last labels' text hangs over the edges of the x axis range. | ||
| * Setting this to `true` will force the first and last labels to align in such a way that their text does | ||
| * not exceed the x range. That is, the first label will be text-anchor: "start" instead of "middle", and | ||
| * the label marking the right edge of the chart will be anchored to the "end" instead of "middle". |
acmei
added a commit
that referenced
this pull request
Dec 10, 2020
* 'gh-pages' of github.com:spotify/reactochart: (45 commits) Gh pages v3.2.1 (#272) Gh pages v3.2.0 (#270) Update docs v3.1 v3.1.0 release Update CHANGELOG.md 3.1.0 add alignment prop for domain start and end label to keep within chart footprint (#264) Gh pages v3.0.3 (#261) v3.0.3 release 3.0.3 Fix issue with RangeBarChart test (#260) Generate docs and add tests for onClick handler (#258) allow for onclick event handlers (#257) Update sinon to the latest version 🚀 (#235) Greenkeeper/husky 4.2.3 (#239) chore(package): update raw-loader to version 4.0.0 (#197) Greenkeeper/react docgen 5.1.0 (#233) v3.0.2 release 3.0.2 Remove deprecated Lifecycle hooks (#234) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is functionally to make this visual difference, keeping both the spacing calculation and visual treatment of the first and potentially last labels rest with alignment setting them within the footprint of the chart.
Check out the normal x axis label alignment: centered under the point
With noLabelOverhang first and last labels (being both the min and max of the charted width) aligning to fall within the vertical footprint of the chart.