Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add alignment prop for domain start and end label to keep within chart footprint #264

Merged
merged 5 commits into from
Jul 9, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/XAxis.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ export default class XAxis extends React.Component {
labelFormat: PropTypes.func,
labelFormats: PropTypes.array,
labels: PropTypes.array,
noLabelOverhang: PropTypes.bool,
/**
* Adds horizontal offset (along the XAxis) to the labels
*/
Expand Down
24 changes: 22 additions & 2 deletions src/XAxisLabels.js
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,16 @@ class XAxisLabels extends React.Component {
* width - width of the given label
*/
labels: PropTypes.array,
/**
* Default label behavior places the text centered below the data point it delineates. This can allow
* overhang where the first and possibly last labels' text hangs over the edges of the x axis range.
* Setting this to `true` will force the first and last labels to align in such a way that their text does
* not exceed the x range. That is, the first label will be text-anchor: "start" instead of "middle", and
* the label marking the right edge of the chart will be anchored to the "end" instead of "middle".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great explanation!

*
* This affects spacing calculations.
*/
noLabelOverhang: PropTypes.bool,
/**
* Round ticks to capture extent of given x domain from XYPlot.
*/
Expand Down Expand Up @@ -246,10 +256,14 @@ class XAxisLabels extends React.Component {
const marginY = max(
labels.map(label => Math.ceil(distance + label.height)),
);
let textAnchor = 'middle';
if (propsWithDefaults.noLabelOverhang) {
textAnchor = 'start';
}
const [marginLeft, marginRight] = getLabelsXOverhang(
xScale,
labels,
'middle',
textAnchor,
);

return defaults(
Expand Down Expand Up @@ -331,9 +345,15 @@ class XAxisLabels extends React.Component {
? bindTrailingArgs(callback, label.value)
: null;
});
let textAnchor = 'middle';
if (this.props.noLabelOverhang) {
if (i === 0) textAnchor = 'start';
if (i === labels.length - 1 && xScale.range()[1] === x)
textAnchor = 'end';
}

const style = defaults(
{ textAnchor: 'middle' },
{ textAnchor },
getValue(labelStyle, { x, y, ...label }, i),
XAxisLabels.defaultProps.labelStyle,
);
Expand Down
2 changes: 2 additions & 0 deletions src/utils/Axis.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ export function getAxisChildProps(props) {
labelFormats,
labelOffset,
labels,
noLabelOverhang,
gridLineClassName,
gridLineStyle,
onMouseEnterLabel,
Expand Down Expand Up @@ -88,6 +89,7 @@ export function getAxisChildProps(props) {
labels,
labelClassName,
labelStyle,
noLabelOverhang,
distance: labelDistance,
format: labelFormat,
formats: labelFormats,
Expand Down
209 changes: 105 additions & 104 deletions tests/jsdom/spec/utils.Axis.spec.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import { expect } from "chai";
import * as d3 from "d3";
import _ from "lodash";
import { expect } from 'chai';
import * as d3 from 'd3';
import _ from 'lodash';
import {
getAxisChildProps,
getMouseAxisOptions
} from "../../../src/utils/Axis";
getMouseAxisOptions,
} from '../../../src/utils/Axis';

describe("Axis utils", () => {
it("getAxisChildProps", () => {
describe('Axis utils', () => {
it('getAxisChildProps', () => {
const axisProps = {
width: 400,
height: 250,
Expand All @@ -17,203 +17,204 @@ describe("Axis utils", () => {
spacingBottom: 10,
spacingLeft: 10,
spacingRight: 10,
position: "top",
placement: "",
position: 'top',
placement: '',
ticks: [10, 20, 30, 40, 50],
tickCount: 5,
tickLength: 8,
tickClassName: "my-ticks",
tickStyle: { stroke: "blue" },
title: "what a title",
tickClassName: 'my-ticks',
tickStyle: { stroke: 'blue' },
title: 'what a title',
titleDistance: 12,
titleAlign: "center",
titleAlign: 'center',
titleRotate: true,
titleStyle: { color: "blue" },
titleStyle: { color: 'blue' },
labelDistance: 12,
labelClassName: "my-label",
labelStyle: { color: "brown" },
labelFormat: "0a",
labelFormats: ["0a"],
labels: ["what a label"],
gridLineClassName: "my-grid",
labelClassName: 'my-label',
labelStyle: { color: 'brown' },
labelFormat: '0a',
labelFormats: ['0a'],
labels: ['what a label'],
gridLineClassName: 'my-grid',
labelOffset: 10,
gridLineStyle: { stroke: "blue" },
gridLineStyle: { stroke: 'blue' },
onMouseEnterLabel: () => {},
onMouseMoveLabel: () => {},
onMouseLeaveLabel: () => {},
onMouseClickLabel: () => {}
onMouseClickLabel: () => {},
};

const {
ticksProps,
gridProps,
labelsProps,
titleProps
titleProps,
} = getAxisChildProps(axisProps);

expect(ticksProps).to.eql(
_.pick(axisProps, [
"width",
"height",
"xScale",
"yScale",
"ticks",
"tickCount",
"spacingTop",
"spacingBottom",
"spacingLeft",
"spacingRight",
"position",
"placement",
"tickLength",
"tickStyle",
"tickClassName"
])
'width',
'height',
'xScale',
'yScale',
'ticks',
'tickCount',
'spacingTop',
'spacingBottom',
'spacingLeft',
'spacingRight',
'position',
'placement',
'tickLength',
'tickStyle',
'tickClassName',
]),
);

expect(gridProps).to.eql(
Object.assign(
{},
_.pick(axisProps, [
"width",
"height",
"xScale",
"yScale",
"ticks",
"tickCount",
"spacingTop",
"spacingBottom",
"spacingLeft",
"spacingRight"
'width',
'height',
'xScale',
'yScale',
'ticks',
'tickCount',
'spacingTop',
'spacingBottom',
'spacingLeft',
'spacingRight',
]),
{
lineClassName: axisProps.gridLineClassName,
lineStyle: axisProps.gridLineStyle
}
)
lineStyle: axisProps.gridLineStyle,
},
),
);

expect(labelsProps).to.eql(
Object.assign(
{},
{ noLabelOverhang: undefined },
_.pick(axisProps, [
"width",
"height",
"xScale",
"yScale",
"ticks",
"tickCount",
"spacingTop",
"spacingBottom",
"spacingLeft",
"spacingRight",
"position",
"placement",
"labels",
"labelClassName",
"labelStyle",
"onMouseEnterLabel",
"onMouseMoveLabel",
"onMouseLeaveLabel",
"onMouseClickLabel"
'width',
'height',
'xScale',
'yScale',
'ticks',
'tickCount',
'spacingTop',
'spacingBottom',
'spacingLeft',
'spacingRight',
'position',
'placement',
'labels',
'labelClassName',
'labelStyle',
'noLabelOverhang',
'onMouseEnterLabel',
'onMouseMoveLabel',
'onMouseLeaveLabel',
'onMouseClickLabel',
]),
{
distance: axisProps.labelDistance,
format: axisProps.labelFormat,
formats: axisProps.labelFormats,
offset: axisProps.labelOffset
}
)
offset: axisProps.labelOffset,
},
),
);

expect(titleProps).to.eql(
Object.assign(
{},
_.pick(axisProps, [
"width",
"height",
"position",
"placement",
"title",
"spacingTop",
"spacingBottom",
"spacingLeft",
"spacingRight"
'width',
'height',
'position',
'placement',
'title',
'spacingTop',
'spacingBottom',
'spacingLeft',
'spacingRight',
]),
{
style: axisProps.titleStyle,
distance: axisProps.titleDistance,
alignment: axisProps.titleAlign,
rotate: axisProps.titleRotate
}
)
rotate: axisProps.titleRotate,
},
),
);
});

describe("getMouseAxisOptions", () => {
it("throws error on invalid axis type", () => {
describe('getMouseAxisOptions', () => {
it('throws error on invalid axis type', () => {
expect(() => {
getMouseAxisOptions("z", {}, {});
getMouseAxisOptions('z', {}, {});
}).to.throw(Error);
});

it("returns valid mouse options for x axisType", () => {
it('returns valid mouse options for x axisType', () => {
const mockEvent = {
currentTarget: {
getBoundingClientRect: () => {
return {
top: 0,
left: 0,
height: 300,
width: 300
width: 300,
};
}
},
},
clientX: 50,
clientY: 0
clientY: 0,
};

const scale = d3
.scalePoint()
.domain(["a", "b", "c"])
.domain(['a', 'b', 'c'])
.range([0, 100]);

expect(getMouseAxisOptions("x", mockEvent, scale)).to.eql({
expect(getMouseAxisOptions('x', mockEvent, scale)).to.eql({
event: mockEvent,
outerX: 50,
outerY: 0,
xScale: scale,
xValue: "b"
xValue: 'b',
});
});

it("returns valid mouse options for y axisType", () => {
it('returns valid mouse options for y axisType', () => {
const mockEvent = {
currentTarget: {
getBoundingClientRect: () => {
return {
top: 0,
left: 0,
height: 300,
width: 300
width: 300,
};
}
},
},
clientX: 0,
clientY: 50
clientY: 50,
};

const scale = d3
.scalePoint()
.domain(["a", "b", "c"])
.domain(['a', 'b', 'c'])
.range([0, 100]);

expect(getMouseAxisOptions("y", mockEvent, scale)).to.eql({
expect(getMouseAxisOptions('y', mockEvent, scale)).to.eql({
event: mockEvent,
outerX: 0,
outerY: 50,
yScale: scale,
yValue: "b"
yValue: 'b',
});
});
});
Expand Down