Merge pull request #258 from FlipEverything/alias_mapping_bug

Fix for alias mapping bug
spotorm · Jan 18, 2018 · a2787a4 · a2787a4
2 parents dc7613a + 4e5536e
commit a2787a4
Show file tree

Hide file tree

Showing 4 changed files with 41 additions and 5 deletions.
diff --git a/lib/Mapper.php b/lib/Mapper.php
@@ -1011,14 +1011,10 @@ public function convertToPHPValues($entityName, array $data)
     {
         $phpData = [];
         $fields = $entityName::fields();
-        $fieldAliasMappings = $this->entityManager()->fieldAliasMappings();
         $platform = $this->connection()->getDatabasePlatform();
+        $data = $this->resolver()->dataWithOutFieldAliasMappings($data);
         $entityData = array_intersect_key($data, $fields);
         foreach ($data as $field => $value) {
-            if ($fieldAlias = array_search($field, $fieldAliasMappings)) {
-                $field = $fieldAlias;
-            }
-
             // Field is in the Entity definitions
             if (isset($entityData[$field])) {
                 $typeHandler = Type::getType($fields[$field]['type']);

diff --git a/lib/Query/Resolver.php b/lib/Query/Resolver.php
@@ -192,6 +192,23 @@ public function dataWithFieldAliasMappings(array $data)
         return $fieldMappings;
     }
 
+    /**
+     * Taken given aliased field name/value inputs and map them to their non-aliased names
+     */
+    public function dataWithOutFieldAliasMappings(array $data)
+    {
+        // have to call fields() otherwise fieldAliasMappings() would return null on the first entity
+        $this->mapper->entityManager()->fields();
+        $fieldAliasMappings = $this->mapper->entityManager()->fieldAliasMappings();
+        foreach ($fieldAliasMappings as $field => $aliasedField) {
+            if (array_key_exists($aliasedField, $data)) {
+                $data[$field] = $data[$aliasedField];
+                unset($data[$aliasedField]);
+            }
+        }
+        return $data;
+    }
+
     /**
      * Execute provided query and return result
      *

diff --git a/tests/Entity/Legacy.php b/tests/Entity/Legacy.php
@@ -22,6 +22,8 @@ public static function fields()
             'name'         => ['type' => 'string', 'required' => true, 'column' => self::getNameFieldColumnName()],
             'number'       => ['type' => 'integer', 'required' => true, 'column' => self::getNumberFieldColumnName()],
             'date_created' => ['type' => 'datetime', 'value' => new \DateTime(), 'column' => self::getDateCreatedColumnName()],
+            'array'        => ['type' => 'array', 'required' => false],
+            'arrayAliased'=> ['type' => 'array', 'required' => false, 'column' => 'array_aliased']
         ];
     }
 

diff --git a/tests/FieldAlias.php b/tests/FieldAlias.php
@@ -143,4 +143,25 @@ public function testLegacyRelations(Legacy $legacy)
         $this->assertInstanceOf('Spot\Relation\HasMany', $legacy->polymorphic_comments);
         $this->assertEquals(count($legacy->polymorphic_comments), 1);
     }
+
+    public function testFieldAliasMapping() {
+        $testId = 2545;
+        $testArray = ['testKey' => 'testValue'];
+
+        $legacy = new Legacy();
+        $legacy->id = $testId;
+        $legacy->name = 'Something Here';
+        $legacy->number = 5;
+        $legacy->array = $testArray;
+        $legacy->arrayAliased = $testArray;
+
+        $mapper = test_spot_mapper('SpotTest\Entity\Legacy');
+        $mapper->save($legacy);
+
+        unset($legacy);
+        $legacy = $mapper->get($testId);
+
+        $this->assertEquals($testArray, $legacy->array);
+        $this->assertEquals($testArray, $legacy->arrayAliased);
+    }
 }