Fix for alias mapping bug #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlipEverything
force-pushed
the
alias_mapping_bug
branch
from
72b49e1
to
4e5536e
Compare
vlucas
approved these changes
Jan 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have an entity defined with field alias mapping then in the
$dataarray the value will be referenced by the aliased name. After thearray_intersect_key($data, $fields)filter it seems that the aliased column is not in the entity definition, but that is not true.I provided tests for this bug in my first commit and after applying my patch in the second commit the tests passed successfully.
You can find more details inside the mentioned issues (#237, #145).