Decouple BeanDefinitionRegistryPostProcessor implementations
#8611
Comments
snicoll
added
status: waiting-for-triage
artembilan
added
in: core
and removed
status: waiting-for-triage
|
Sure! What deadline should we aim this for, please? |
|
If we change something, it will be in Spring Framework 6.1 at the earliest. Thanks! |
artembilan
added a commit
to artembilan/spring-integration
that referenced
this issue
Jun 27, 2023
Fixes spring-projects#8611 According to the latest Spring Framework requirements related to AOT the `BeanDefinitionRegistryPostProcessor` must not do anything but only bean registrations * Extract an `IntegrationConfigurationReport` component and move `IntegrationProperties` printing over here out from the `DefaultConfiguringBeanFactoryPostProcessor` * Remove a `SmartInitializingSingleton` impl from the `DefaultConfiguringBeanFactoryPostProcessor`
garyrussell
pushed a commit
that referenced
this issue
Jun 27, 2023
Fixes #8611 According to the latest Spring Framework requirements related to AOT the `BeanDefinitionRegistryPostProcessor` must not do anything but only bean registrations * Extract an `IntegrationConfigurationReport` component and move `IntegrationProperties` printing over here out from the `DefaultConfiguringBeanFactoryPostProcessor` * Remove a `SmartInitializingSingleton` impl from the `DefaultConfiguringBeanFactoryPostProcessor`
|
Reopen for |
artembilan
added a commit
to artembilan/spring-integration
that referenced
this issue
Jun 27, 2023
Fixes spring-projects#8611 According to the latest Spring Framework requirements related to AOT the `BeanDefinitionRegistryPostProcessor` must not do anything but only bean registrations * Extract a `MessagingAnnotationBeanPostProcessor` component with a `BeanPostProcessor` logic from the `MessagingAnnotationPostProcessor` and leave the last one as just a `BeanDefinitionRegistryPostProcessor` impl * Fix tests according to a new logic
garyrussell
pushed a commit
that referenced
this issue
Jun 28, 2023
Fixes #8611 According to the latest Spring Framework requirements related to AOT the `BeanDefinitionRegistryPostProcessor` must not do anything but only bean registrations * Extract a `MessagingAnnotationBeanPostProcessor` component with a `BeanPostProcessor` logic from the `MessagingAnnotationPostProcessor` and leave the last one as just a `BeanDefinitionRegistryPostProcessor` impl * Fix tests according to a new logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While reviewing an issue in Spring Framework, I've noticed that Spring Integration has BeanDefinitionRegistryPostProcessor implementations that are also doing something else.
We're considering reviewing this contract so that such post-processors are automatically excluded from AOT processing (as they operation on the bean factory that's pre-processed by it). Can you please review
DefaultConfiguringBeanFactoryPostProcessorandMessagingAnnotationPostProcessorso that they only perform bean definition registry post-processing and nothing else?The text was updated successfully, but these errors were encountered: