Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-8611: Extract IntegrationConfigurationReport #8660

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

artembilan
Copy link
Member

Fixes #8611

According to the latest Spring Framework requirements related to AOT the BeanDefinitionRegistryPostProcessor must not do anything but only bean registrations

  • Extract an IntegrationConfigurationReport component and move IntegrationProperties printing over here out from the DefaultConfiguringBeanFactoryPostProcessor
  • Remove a SmartInitializingSingleton impl from the DefaultConfiguringBeanFactoryPostProcessor

Fixes spring-projects#8611

According to the latest Spring Framework requirements related to AOT the
`BeanDefinitionRegistryPostProcessor` must not do anything but only bean registrations

* Extract an `IntegrationConfigurationReport` component
and move `IntegrationProperties` printing over here out from the
`DefaultConfiguringBeanFactoryPostProcessor`
* Remove a `SmartInitializingSingleton` impl from the `DefaultConfiguringBeanFactoryPostProcessor`
@artembilan
Copy link
Member Author

This is part 1 since there is yet that MessagingAnnotationPostProcessor which is much complicated to decouple.
So, I'm considering that as a separate PR since it is going to be much involved and would over complicate review for this simpler part.

@garyrussell garyrussell merged commit 13980af into spring-projects:main Jun 27, 2023
@artembilan artembilan deleted the GH-8611 branch June 27, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decouple BeanDefinitionRegistryPostProcessor implementations
2 participants