-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default @Retryable has 1s blocking back-off despite docs saying otherwise #93
Comments
garyrussell
added a commit
to garyrussell/spring-retry
that referenced
this issue
Nov 28, 2017
Previously, if a bean annotated with `@Retryable` and `@Recover` was scoped "prototype", the `@Recover` method in the first instance was called instead of the method in the same instance as the failed `@Retryable` method. This was because the delegate cache in `AnnotationAwareRetryOperationsInterceptor` was keyed only on the `Method` object. Change the cache to cache at the `targetObject.method` level. Also fixes `backoff` javadocs. Fixes spring-projects#93
garyrussell
added a commit
to garyrussell/spring-retry
that referenced
this issue
Nov 28, 2017
Previously, if a bean annotated with `@Retryable` and `@Recover` was scoped "prototype", the `@Recover` method in the first instance was called instead of the method in the same instance as the failed `@Retryable` method. This was because the delegate cache in `AnnotationAwareRetryOperationsInterceptor` was keyed only on the `Method` object. Change the cache to cache at the `targetObject.method` level. Also fixes `backoff` javadocs. Fixes spring-projects#93
dsyer
pushed a commit
that referenced
this issue
Dec 5, 2017
Previously, if a bean annotated with `@Retryable` and `@Recover` was scoped "prototype", the `@Recover` method in the first instance was called instead of the method in the same instance as the failed `@Retryable` method. This was because the delegate cache in `AnnotationAwareRetryOperationsInterceptor` was keyed only on the `Method` object. Change the cache to cache at the `targetObject.method` level. Also fixes `backoff` javadocs. Fixes #93
I reverted #88 because there is a failing test for me. Not sure why yet. |
Re-opened in case we actually want to change the default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The docs for retryable annotation state that default behaviour is no backoff:
but a default
@Backoff
annotation would have a backoff of 1s as mentioned in:and used by https://github.com/spring-projects/spring-retry/blob/master/src/main/java/org/springframework/retry/annotation/AnnotationAwareRetryOperationsInterceptor.java#L319
The text was updated successfully, but these errors were encountered: