Fix @Recover for Prototype Scoped Beans #96
Merged
+138
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if a bean annotated with `@Retryable` and `@Recover` was scoped "prototype", the `@Recover` method in the first instance was called instead of the method in the same instance as the failed `@Retryable` method. This was because the delegate cache in `AnnotationAwareRetryOperationsInterceptor` was keyed only on the `Method` object. Change the cache to cache at the `targetObject.method` level. Also fixes `backoff` javadocs. Fixes spring-projects#93
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a bean annotated with
@Retryableand@Recoverwasscoped "prototype", the
@Recovermethod in the first instance wascalled instead of the method in the same instance as the failed
@Retryablemethod.
This was because the delegate cache in
AnnotationAwareRetryOperationsInterceptorwas keyed only on the
Methodobject.Change the cache to cache at the
targetObject.methodlevel.Also fixes
backoffjavadocs.Fixes #93