Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Flow for static type checking (#127) #178

Merged
merged 29 commits into from
Feb 5, 2019
Merged

Add Flow for static type checking (#127) #178

merged 29 commits into from
Feb 5, 2019

Conversation

thibaudcolas
Copy link
Collaborator

@thibaudcolas thibaudcolas commented Jan 7, 2019 •
edited
Loading

See #127.

  • Set up flow-bin as a dependency
  • Add .flowconfig based on the one in draftjs-filters
  • Set up in CI
  • Add to Rollup build (strip Flow types)
  • Start by adding types (// @flow and the type annotations) to behavior.js or DraftUtils.js.
  • Remove prop-types dependency

@thibaudcolas thibaudcolas added the enhancement New feature or request label Jan 7, 2019
@thibaudcolas thibaudcolas added this to the v1.1.0 milestone Jan 7, 2019
@thibaudcolas
Add basic Flow configuration to the project
2c7a4f6
@thibaudcolas
Start adding Flow type annotations in the examples
6949070
@thibaudcolas
Add integrations of Flow with other tools
6c93035
@thibaudcolas
Improve new type definitions of example components
6d80f19
@thibaudcolas
Use ESLint plugin for Flow type definitions
081b04b
@thibaudcolas
Add type definitions for code reliant on 3rd-party libs
9a28d57
@thibaudcolas
Add Flow types for most of the examples code
6bff6eb
@thibaudcolas
Add type definitions for example blocks
6699dea
@thibaudcolas
Add Flow types for all remaining examples code
5605fc0
@thibaudcolas
Disable sketchy-null check for strings
2fccb32
@thibaudcolas
Update draftjs-filters to latest for new Flow type definitions
da19857
@thibaudcolas
Update draftjs-conductor dependency to latest
9c8a0d9
@thibaudcolas
Update to latest flow-bin
831dea8
@thibaudcolas
Update draftjs-conductor dependency to latest
ae7907b
@thibaudcolas
Update draftjs-filters to latest for new Flow type definitions
b555bdd
@thibaudcolas
Start typing parts of library code with Flow
d8197d9
@thibaudcolas
Fix snapshot tests due to draftjs-conductor API change
5f3d57e
@thibaudcolas
Add more type definitions to Draftail library code
bd4b162
@thibaudcolas
Handle case where tryToRemoveBlockStyle returns null in handleHardNew…
f3bbaed 
…line
@thibaudcolas
Start adding type annotations for React lib code
0f701ea
@thibaudcolas thibaudcolas changed the title [WIP] Add Flow for static type checking (#127) Add Flow for static type checking (#127) Feb 5, 2019
@thibaudcolas thibaudcolas merged commit 49efd64 into master Feb 5, 2019
@thibaudcolas thibaudcolas deleted the chore/flow-types branch February 5, 2019 20:12
This was referenced Feb 5, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@thibaudcolas