Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Update ipykernel constraint to >=6.16.1 #426

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz added this to the v2.4.0 milestone Oct 27, 2022
@dalthviz dalthviz self-assigned this Oct 27, 2022
@ccordoba12
Copy link
Member

@dalthviz, I'm going to push a commit to your branch to fix the failing test. The failure is caused by PR ipython/ipykernel#1008, which is precisely the change we want to depend on by increasing IPykernel to 6.16.1 since it fixes a quite serious memory leak.

- This uses the kernel API for event loops directly instead of relying
on a private Matplotlib function.
- It also fixes the detection of the Tk backend, which was broken with
the release of IPykernel 6.16.1
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz!

@ccordoba12 ccordoba12 merged commit 6fa5520 into spyder-ide:2.x Oct 31, 2022
ccordoba12 added a commit that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants