Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add the Debug Cell icon to the debug toolbar #18833

Closed

Conversation

stevetracvc
Copy link
Contributor

Description of Changes

I added the "Debug Cell" icon to the toolbar.

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Before
debug

After
debug2

I find it extremely annoying that all of the major Debug tools are in the toolbar except for the Debug Cell tool. And sometimes, when trying to click on it from the Debug menu, I accidentally hit the "Run File" toolbar icon instead. This PR adds the icon, keeping the same ordering that is used in the Debug menu.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: stevetracvc

@stevetracvc stevetracvc changed the title Added the Debug Cell icon to the debug toolbar PR: Add the Debug Cell icon to the debug toolbar Jul 27, 2022
@impact27
Copy link
Contributor

Looks good to me!

@dalthviz
Copy link
Member

I guess this will need a rebase running something like #18691 (comment) but with master instead of 5.x right @impact27 ?

@stevetracvc
Copy link
Contributor Author

I guess this will need a rebase running something like #18691 (comment) but with master instead of 5.x right @impact27 ?

Ok I was watching that other PR but wasn't 100% sure what I needed to do yet. I'll try that when I get home.

@stevetracvc stevetracvc deleted the feat/debug-cell-toolbar branch July 30, 2022 20:02
@stevetracvc
Copy link
Contributor Author

I deleted and recreated this at #18877 since it was too big a hassle to figure out how to handle the CR issue for a one-line PR. 😄

@ccordoba12 ccordoba12 removed this from the v6.0alpha1 milestone Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants