-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add debug cell icon to the debug toolbar #18877
PR: Add debug cell icon to the debug toolbar #18877
Conversation
looks good to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stevetracvc ! This LGTM 👍
However, just in case, could be worthy to do this over 5.x? What do you think @impact27 @ccordoba12 ?
If not, then I think we should proceed with this and merge 👍🏼
5.x sounds good to me |
@impact27 looks like @ccordoba12 did that too, switched back and forth immediately. Is there something I need to do to make it work with 5.x instead? |
Yep @stevetracvc to move to 5.x this will need a rebase. For that I think the command is something like Also, sorry for all the hassle in order to land a one line change 😅. Hopefully after the rebase this could be merged without problem 🤞🏼 |
hmmmmm I think the issue is the CRLF stuff again 🤣 hang on |
Could it be better to just recreate this PR again but this time using as base branch 5.x for your feature branch locally @stevetracvc ? |
I'm not sure about adding this button to 5.x because it'd change the default interface and so it'd make harder for users to follow our docs. So I'd say we should leave it for master (i.e. the future Spyder 6). That's something we agreed on with @impact27 already. |
Then this LGTM 👍 Thanks @stevetracvc ! |
I recreated this after the CRLF PR
Description of Changes
I added the "Debug Cell" icon to the toolbar.
Before

After

I find it extremely annoying that all of the major Debug tools are in the toolbar except for the Debug Cell tool. And sometimes, when trying to click on it from the Debug menu, I accidentally hit the "Run File" toolbar icon instead. This PR adds the icon, keeping the same ordering that is used in the Debug menu.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: stevetracvc