-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: [5.x branch] Allow ipython 8+ v2 #19817
Conversation
…debakpt/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "b4fa4c2b2" upstream: origin: "https://github.com/eendebakpt/spyder-kernels.git" branch: "ipython8_2x" commit: "b4fa4c2b2" git-subrepo: version: "0.4.5" origin: "???" commit: "???"
Closing and reopening to see if our tests run. |
@eendebakpt, some comments for you:
|
@ccordoba12 ipython 8+ does not support python 3.7 any longer (from the setup.py: |
…debakpt/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "0a91ca7db" upstream: origin: "https://github.com/eendebakpt/spyder-kernels.git" branch: "ipython8_2x" commit: "0a91ca7db" git-subrepo: version: "0.4.5" origin: "???" commit: "???"
@ccordoba12 I am not familiar with conda. Most tests fail because:
This also happens on the Linux tests, even though Do you have an idea what is going on? |
Right, I forgot about it. So we need to change the requirement to https://github.com/spyder-ide/spyder/actions/runs/3243542112/jobs/5318406491#step:11:115
Nop, sorry. But a way to solve this could be to force installing IPython 8 in our |
…nto ipython8_5x_v2
@ccordoba12 For some reason I cannot get the dependencies right between the spyder-kernels and spyder reposities. But the Besides some tests related to the package versions ( |
Ok, thanks a lot for your help with this! Unfortunately, I don't have time right now to fix our CIs so that they pass for all operating systems and Python versions. So, I'm afraid this will have to wait until 5.4.1, to be released in December. |
Closing because this was superseded by PR #20271. |
Description of Changes
Test Spyder with ipython 8+
Create Windows Installer / Windows installer (Lite)
will fail since the updated spyder-kernels is not available in condaIssue(s) Resolved
Fixes #
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: