Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: [5.x branch] Allow ipython 8+ v2 #19817

Closed
wants to merge 12 commits into from

Conversation

eendebakpt
Copy link
Contributor

@eendebakpt eendebakpt commented Oct 13, 2022

Description of Changes

Test Spyder with ipython 8+

  • Tests in python 3.7 will fail since ipython 8+ is not available
  • ? Create Windows Installer / Windows installer (Lite) will fail since the updated spyder-kernels is not available in conda

Issue(s) Resolved

Fixes #

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

…debakpt/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "b4fa4c2b2"
upstream:
  origin:   "https://github.com/eendebakpt/spyder-kernels.git"
  branch:   "ipython8_2x"
  commit:   "b4fa4c2b2"
git-subrepo:
  version:  "0.4.5"
  origin:   "???"
  commit:   "???"
@eendebakpt eendebakpt changed the base branch from master to 5.x October 13, 2022 14:54
@ccordoba12
Copy link
Member

Closing and reopening to see if our tests run.

@ccordoba12 ccordoba12 closed this Oct 13, 2022
@ccordoba12 ccordoba12 reopened this Oct 13, 2022
@ccordoba12
Copy link
Member

@eendebakpt, some comments for you:

  • I don't know why but we're not installing IPython 8 on Github actions:

    https://github.com/spyder-ide/spyder/actions/runs/3243542120/jobs/5318407187#step:12:128

    So, I'd suggest to change our dependency on IPython to be >=8.5.0,<9 to force our tests to really run with IPython 8. Besides, trying to support IPython 7 and 8 is too much for us, so I think it's better go only with 8 from now on.

  • You also need to update the requirement in our setup.py.

  • Please also make the >=8.5.0,<9 change in your Spyder-kernels PR and resync our subrepo here following the instructions in our Contributing guide.

@eendebakpt
Copy link
Contributor Author

@ccordoba12 ipython 8+ does not support python 3.7 any longer (from the setup.py: IPython 8+ supports Python 3.8 and above, following NEP 29.). I will look into the tests for 3.8+

…debakpt/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "0a91ca7db"
upstream:
  origin:   "https://github.com/eendebakpt/spyder-kernels.git"
  branch:   "ipython8_2x"
  commit:   "0a91ca7db"
git-subrepo:
  version:  "0.4.5"
  origin:   "???"
  commit:   "???"
@eendebakpt
Copy link
Contributor Author

@ccordoba12 I am not familiar with conda. Most tests fail because:

- nothing provides __win needed by ipython-8.5.0-pyh08f2357_1

This also happens on the Linux tests, even though __win is a virtual package related to windows (https://docs.conda.io/projects/conda/en/latest/user-guide/tasks/manage-virtual.html).

Do you have an idea what is going on?

@ccordoba12
Copy link
Member

ipython 8+ does not support python 3.7 any longer

Right, I forgot about it. So we need to change the requirement to >=7.31.1,<9. However, your previous run was not picking up IPython 8 even for Python 3.9:

https://github.com/spyder-ide/spyder/actions/runs/3243542112/jobs/5318406491#step:11:115
https://github.com/spyder-ide/spyder/actions/runs/3243542104/jobs/5318406138#step:11:114

Do you have an idea what is going on?

Nop, sorry. But a way to solve this could be to force installing IPython 8 in our install.sh script for Python 3.9. Please try that for the pip part of the big if on it. That at least will run our tests on some Windows and Linux slots.

@eendebakpt
Copy link
Contributor Author

@ccordoba12 For some reason I cannot get the dependencies right between the spyder-kernels and spyder reposities. But the Linux tests / Linux - Py3.9, conda, slow (pull_request) and Win tests / Windows - Py3.9, pip, slow (pull_request are running now with ipython 8+.

Besides some tests related to the package versions (test_dependencies_in_sync.py), there was only a single failing test. I created a separate PR to the 5.x branch to address this: #19885

@dalthviz dalthviz mentioned this pull request Oct 19, 2022
11 tasks
@ccordoba12
Copy link
Member

Ok, thanks a lot for your help with this! Unfortunately, I don't have time right now to fix our CIs so that they pass for all operating systems and Python versions.

So, I'm afraid this will have to wait until 5.4.1, to be released in December.

@eendebakpt eendebakpt marked this pull request as draft October 21, 2022 13:49
@dalthviz dalthviz added this to the v5.4.1 milestone Nov 2, 2022
@ccordoba12 ccordoba12 removed this from the v5.4.1 milestone Dec 28, 2022
@ccordoba12
Copy link
Member

Closing because this was superseded by PR #20271.

@ccordoba12 ccordoba12 closed this Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants