-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add wrap lines action in Source menu and shortcut for it #20090
base: 5.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @maurerle for reviving @arteagac's contribution! I tested this locally and it's working as expected.
However, I'd be in favor of wrapping lines per file instead of doing it for all files (as in this PR). That's why I'd suggest to change wrap_lines_action
to be a regular action (i.e. non-checkable), such as trailingspaces_action
, which only has effect for the current file.
By doing that, we'll also be able to remove this option in our Preferences:
which I think is of little value because you don't want to see all your files wrapped.
This is a display/visualization setting which has two states (wrap lines on or off) I don't think that something without a checkbox is sufficient here. Notepad++ has this feature implemented as it is currently in spyder (once for all views). I actually like the behavior as it is best. |
0e47823
to
b4200cb
Compare
b4200cb
to
18c9cc7
Compare
Wouldn't this be a nice addition to the 6.0 release too? 😊 |
18c9cc7
to
c830a1c
Compare
c830a1c
to
9898772
Compare
Description of Changes
Added wrap lines Command in Source Menu
Added Alt + Z as a shortcut for it, as it is used by VSCode and this shortcut is currently unused
Issue(s) Resolved
Supersedes #13496
Fixes #7997
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: Florian Maurer