Separate sublist for Trino row pattern functions #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just to have all keywords listed there, regardless whether they get overridden by the functions list.
|
@verhovsky FYI. |
|
Not much to review here. Merging straight in. |
|
I did submit a PR to add them to that list, I guess we'll see if they think that makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganizing the code added in: 03d6bff
Instead of placing the row functions inside the main functions list, separated them out, so that when one goes to review the functions list in the future, one wouldn't expect to find these functions in the Trino functions list.
Also restored
PERMUTEto keywords list, so it lists all the keywords, regardless of whether SQL Formatter also recognizes them as function names.