Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add row pattern recognition functions to list of functions #13327

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

verhovsky
Copy link
Contributor

@verhovsky verhovsky commented Jul 24, 2022

@cla-bot cla-bot bot added the cla-signed label Jul 24, 2022
@github-actions github-actions bot added the docs label Jul 24, 2022
@verhovsky verhovsky changed the title Add row pattern recognition expression functions to list of functions Add row pattern recognition functions to list of functions Jul 24, 2022
@ebyhr ebyhr requested a review from mosabua November 16, 2022 06:43
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mosabua
Copy link
Member

mosabua commented May 11, 2023

Could you resolve the conflict @verhovsky ?

@verhovsky
Copy link
Contributor Author

In a week or two maybe.

@mosabua
Copy link
Member

mosabua commented Jul 7, 2023

Ping ..

Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing and fixing!

@mosabua mosabua merged commit 3d708d4 into trinodb:master Jul 10, 2023
@mosabua
Copy link
Member

mosabua commented Jul 10, 2023

Btw .. I will add sql-formatter as an add-on tool listed on the trino.io website.

Also note that the Trino and Presto dialect are NOT the same at this stage.

@github-actions github-actions bot added this to the 422 milestone Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants