Fix parsing types and add check to test in future #2652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2652 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 163 163
Lines 12000 12014 +14
=========================================
+ Hits 12000 12014 +14
Continue to review full report at Codecov.
|
|
This is quite a big change, but most are YML changes, so suggest when reviewing you filter those out:
Then check the change, then if comfortable with the code changes, spot check a few YML file changes. |
barrywhart
requested changes
Feb 15, 2022
| if tree: | ||
|
|
||
| # Check we don't have any base types or unparsable sections | ||
| types = tree.type_set() |
There was a problem hiding this comment.
Yes I've been meaning to add an unparsable check for ages. Stops code reviewers having to check for this. Pretty pleased we have this now. And checking for no base segments is an added bonus.
Co-authored-by: Barry Hart <barrywhart@yahoo.com>
Co-authored-by: Barry Hart <barrywhart@yahoo.com>
barrywhart
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
Fixes #2650 which was caused by statements which did not have a
typeset, so fell back tobasetype whereas rule L052 expected them to be statements.I've also added a change to L052 to raise these errors in future instead of a debugging error that is not checked in CI.
I also added types to all other segments that were missing them.
Finally I added a check to the generate_parse_fixture_yml.py script to check if any segment is set to
baseorunparsableand alert in this case so we can catch this in future.Are there any other side effects of this change that we should be aware of?
As per above.
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withtox -e generate-fixture-yml).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.