Fix parsing types and add check to test in future

src/sqlfluff/dialects/dialect_ansi.py

@@ -3058,6 +3058,7 @@ class SetClauseSegment(BaseSegment):
 class FunctionDefinitionGrammar(BaseSegment):
     """This is the body of a `CREATE FUNCTION AS` statement."""
 
+    type = "function_definition"
     match_grammar = Sequence(
         "AS",
         Ref("QuotedLiteralSegment"),
@@ -3113,6 +3114,7 @@ class CreateFunctionStatementSegment(BaseSegment):
 class FunctionParameterListGrammar(BaseSegment):
     """The parameters for a function ie. `(string, number)`."""
 
+    type = "function_parameter_list"
     # Function parameter list
     match_grammar = Bracketed(
         Delimited(

src/sqlfluff/dialects/dialect_bigquery.py

@@ -467,6 +467,7 @@ class FunctionSegment(BaseSegment):
 class FunctionDefinitionGrammar(BaseSegment):
     """This is the body of a `CREATE FUNCTION AS` statement."""
 
+    type = "function_definition"
     match_grammar = Sequence(
         AnyNumberOf(
             Sequence(
@@ -599,6 +600,7 @@ class FunctionParameterListGrammar(BaseSegment):
 
     # Function parameter list. Note that the only difference from the ANSI
     # grammar is that BigQuery provides overrides bracket_pairs_set.
+    type = "function_parameter_list"
     match_grammar = Bracketed(
         Delimited(
             Ref("FunctionParameterGrammar"),

src/sqlfluff/dialects/dialect_mysql.py

@@ -685,6 +685,7 @@ class CreateProcedureStatementSegment(BaseSegment):
 class FunctionDefinitionGrammar(BaseSegment):
     """This is the body of a `CREATE FUNCTION` statement."""
 
+    type = "function_definition"
     match_grammar = Ref("TransactionStatementSegment")
 
 
@@ -848,6 +849,7 @@ class AlterTableStatementSegment(BaseSegment):
 class ProcedureParameterListGrammar(BaseSegment):
     """The parameters for a procedure ie. `(in/out/inout name datatype)`."""
 
+    type = "procedure_parameter_list"
     match_grammar = Bracketed(
         Delimited(
             Ref("ProcedureParameterGrammar"),

src/sqlfluff/dialects/dialect_postgres.py

@@ -871,6 +871,7 @@ class FunctionDefinitionGrammar(BaseSegment):
     https://www.postgresql.org/docs/13/sql-createfunction.html
     """
 
+    type = "function_definition"
     match_grammar = Sequence(
         AnyNumberOf(
             Ref("LanguageClauseSegment"),
@@ -2212,6 +2213,7 @@ class PartitionBoundSpecSegment(BaseSegment):
     As per https://www.postgresql.org/docs/13/sql-altertable.html.
     """
 
+    type = "partition_bound_segment"
     match_grammar = OneOf(
         Sequence(
             "IN",
@@ -2322,6 +2324,7 @@ class TableConstraintUsingIndexSegment(BaseSegment):
     As specified in: https://www.postgresql.org/docs/13/sql-altertable.html.
     """
 
+    type = "table_constraint_segment"
     match_grammar = Sequence(
         Sequence(  # [ CONSTRAINT <Constraint name> ]
             "CONSTRAINT", Ref("ObjectReferenceSegment"), optional=True

src/sqlfluff/dialects/dialect_snowflake.py

@@ -520,6 +520,7 @@ class ValuesClauseSegment(BaseSegment):
 class FunctionDefinitionGrammar(BaseSegment):
     """This is the body of a `CREATE FUNCTION AS` statement."""
 
+    type = "function_definition"
     match_grammar = Sequence(
         "AS",
         OneOf(Ref("QuotedLiteralSegment"), Ref("DollarQuotedLiteralSegment")),
@@ -3359,6 +3360,7 @@ class DescribeStatementSegment(BaseSegment):
     https://docs.snowflake.com/en/sql-reference/sql/desc.html
     """
 
+    type = "describe_statement"
     match_grammar = Sequence(
         OneOf("DESCRIBE", "DESC"),
         OneOf(
@@ -3535,6 +3537,7 @@ class TransactionStatementSegment(BaseSegment):
     https://docs.snowflake.com/en/sql-reference/sql/rollback.html
     """
 
+    type = "transaction_statement_segment"
     match_grammar = OneOf(
         Sequence(
             "BEGIN",

src/sqlfluff/dialects/dialect_spark3.py

@@ -1553,6 +1553,7 @@ class RefreshFunctionStatementSegment(BaseSegment):
 class StatementSegment(BaseSegment):
     """Overriding StatementSegment to allow for additional segment parsing."""
 
+    type = "statement"
     match_grammar = ansi_dialect.get_segment("StatementSegment").match_grammar.copy()
 
     parse_grammar = ansi_dialect.get_segment("StatementSegment").parse_grammar.copy(

src/sqlfluff/dialects/dialect_tsql.py

@@ -2969,6 +2969,7 @@ class PostTableExpressionGrammar(BaseSegment):
     https://docs.microsoft.com/en-us/sql/t-sql/queries/hints-transact-sql-table?view=sql-server-ver15
     """
 
+    type = "post_table_expression_grammar"
     match_grammar = Sequence(
         Sequence("WITH", optional=True),
         Bracketed(

src/sqlfluff/rules/L052.py

@@ -152,10 +152,11 @@ def _eval(self, context: RuleContext) -> Optional[LintResult]:
                             break
                         except ValueError:  # pragma: no cover
                             pass
-            else:
-                self.logger.error(
-                    "Unable to identify statement terminated by %r", context.segment
-                )
+            elif memory["ended_statements"]:
+                # Unless it's an empty statement we shouldn't reach here
+                raise ValueError(
+                    f"Unable to identify statement terminated by {context.segment!r}"
+                )  # pragma: no cover
 
             # Locate semicolon and search back over the raw stack
             # to find the end of the preceding statement.

test/fixtures/dialects/ansi/create_function.yml

@@ -3,15 +3,15 @@
 # computed by SQLFluff when running the tests. Please run
 # `python test/generate_parse_fixture_yml.py`  to generate them after adding or
 # altering SQL files.
-_hash: 561d6ce111232861a4bab77ecf23c9cba4b2ed492c6f1538b35f4c59a2e579f4
+_hash: 464777673d070691ae11a20dc3510745429b36256e61c9269c0b247409701c7a
 file:
   statement:
     create_function_statement:
     - keyword: CREATE
     - keyword: FUNCTION
     - function_name:
         function_name_identifier: add
-    - base:
+    - function_parameter_list:
         bracketed:
         - start_bracket: (
         - data_type:
@@ -23,7 +23,7 @@ file:
     - keyword: RETURNS
     - data_type:
         data_type_identifier: integer
-    - base:
+    - function_definition:
       - keyword: AS
       - literal: "'select $1 + $2;'"
       - keyword: LANGUAGE

test/fixtures/dialects/ansi/create_function_no_args.yml

@@ -3,22 +3,22 @@
 # computed by SQLFluff when running the tests. Please run
 # `python test/generate_parse_fixture_yml.py`  to generate them after adding or
 # altering SQL files.
-_hash: f23c156e64e82141c241dbef04aba9cc6d118493c80e4f7e266da13145682b96
+_hash: 19e4092a664affa9d51bbe9365080cbc88e9003c5b17dc2c9259f549b2bc03e2
 file:
   statement:
     create_function_statement:
     - keyword: CREATE
     - keyword: FUNCTION
     - function_name:
         function_name_identifier: add
-    - base:
+    - function_parameter_list:
         bracketed:
           start_bracket: (
           end_bracket: )
     - keyword: RETURNS
     - data_type:
         data_type_identifier: integer
-    - base:
+    - function_definition:
       - keyword: AS
       - literal: "'select $1 + $2;'"
       - keyword: LANGUAGE

test/fixtures/dialects/ansi/create_zero_argument_function.yml

@@ -3,7 +3,7 @@
 # computed by SQLFluff when running the tests. Please run
 # `python test/generate_parse_fixture_yml.py`  to generate them after adding or
 # altering SQL files.
-_hash: 70f3b48d6b9e3569b60dbe7b4860155a93958fb624d2cd0f554c2010a6523abb
+_hash: 519f26f25605bc9c2ea3d93c0758bb28d57354f445d527cbb2ffc53a9260f9ed
 file:
 - statement:
     create_function_statement:
@@ -13,14 +13,14 @@ file:
     - keyword: FUNCTION
     - function_name:
         function_name_identifier: a
-    - base:
+    - function_parameter_list:
         bracketed:
           start_bracket: (
           end_bracket: )
     - keyword: RETURNS
     - data_type:
         data_type_identifier: integer
-    - base:
+    - function_definition:
       - keyword: AS
       - literal: "'\n    SELECT 1;\n'"
       - keyword: LANGUAGE
@@ -32,14 +32,14 @@ file:
     - keyword: FUNCTION
     - function_name:
         function_name_identifier: a
-    - base:
+    - function_parameter_list:
         bracketed:
           start_bracket: (
           end_bracket: )
     - keyword: RETURNS
     - data_type:
         data_type_identifier: integer
-    - base:
+    - function_definition:
       - keyword: AS
       - literal: "'\n    SELECT 1;\n'"
       - keyword: LANGUAGE

test/fixtures/dialects/bigquery/create_function_no_args.yml

@@ -3,22 +3,22 @@
 # computed by SQLFluff when running the tests. Please run
 # `python test/generate_parse_fixture_yml.py`  to generate them after adding or
 # altering SQL files.
-_hash: fa012a4e84dfe072b317e5e5ace48d266ab98c320b14d91491ff85e1f5c33243
+_hash: 71492f64ce880f27b02655dd780bd1c63233f5c037c5c3a0fe99aa0611be442e
 file:
   statement:
     create_function_statement:
     - keyword: CREATE
     - keyword: FUNCTION
     - function_name:
         function_name_identifier: add
-    - base:
+    - function_parameter_list:
         bracketed:
           start_bracket: (
           end_bracket: )
     - keyword: RETURNS
     - data_type:
         data_type_identifier: integer
-    - base:
+    - function_definition:
       - keyword: AS
       - udf_body: "'select $1 + $2;'"
       - keyword: LANGUAGE

test/fixtures/dialects/bigquery/create_js_function_complex_types.yml

@@ -3,7 +3,7 @@
 # computed by SQLFluff when running the tests. Please run
 # `python test/generate_parse_fixture_yml.py`  to generate them after adding or
 # altering SQL files.
-_hash: 4dd3e99e4321a5c62fecad2e1703d9c001452eab142905bbb364c177a361b78b
+_hash: 2a9fb25f37a507a705e3e12b3cb8a48cac10c161235b595779629e6d1577cd46
 file:
   statement:
     create_function_statement:
@@ -12,7 +12,7 @@ file:
     - keyword: FUNCTION
     - function_name:
         function_name_identifier: qs
-    - base:
+    - function_parameter_list:
         bracketed:
         - start_bracket: (
         - parameter: foo1
@@ -87,7 +87,7 @@ file:
             data_type_identifier: INT64
           end_angle_bracket: '>'
         end_angle_bracket: '>'
-    - base:
+    - function_definition:
       - keyword: LANGUAGE
       - parameter: js
       - keyword: AS

test/fixtures/dialects/bigquery/create_js_function_deterministic.yml

@@ -3,22 +3,22 @@
 # computed by SQLFluff when running the tests. Please run
 # `python test/generate_parse_fixture_yml.py`  to generate them after adding or
 # altering SQL files.
-_hash: f4691f284b1f46350285c6dc91a444e7e4198352ba0e960b8c0ef8f2d1d9411d
+_hash: 7f2513b695990453252859cc64731f0c691a79916219ee57e43a3bdc67f41aa8
 file:
   statement:
     create_function_statement:
     - keyword: CREATE
     - keyword: FUNCTION
     - function_name:
         function_name_identifier: qs
-    - base:
+    - function_parameter_list:
         bracketed:
           start_bracket: (
           parameter: y
           data_type:
             data_type_identifier: STRING
           end_bracket: )
-    - base:
+    - function_definition:
       - keyword: DETERMINISTIC
       - keyword: LANGUAGE
       - parameter: js

test/fixtures/dialects/bigquery/create_js_function_options_library_array.yml

@@ -3,7 +3,7 @@
 # computed by SQLFluff when running the tests. Please run
 # `python test/generate_parse_fixture_yml.py`  to generate them after adding or
 # altering SQL files.
-_hash: 65b77a68deca7c57c1220bb182f25aa394e4959608b3b637bfc4789c19537125
+_hash: 74febd125c1eb7fe516c95ef631e854e7c83649e5b3f32a1ec417a20e23d07ce
 file:
   statement:
     create_function_statement:
@@ -12,7 +12,7 @@ file:
     - keyword: FUNCTION
     - function_name:
         function_name_identifier: parseTopSellers
-    - base:
+    - function_parameter_list:
         bracketed:
           start_bracket: (
           parameter: arr_str
@@ -35,7 +35,7 @@ file:
             data_type_identifier: FLOAT64
         - end_angle_bracket: '>'
         end_angle_bracket: '>'
-    - base:
+    - function_definition:
       - keyword: LANGUAGE
       - parameter: js
       - keyword: OPTIONS

test/fixtures/dialects/bigquery/create_js_function_quoted_name.yml

@@ -3,7 +3,7 @@
 # computed by SQLFluff when running the tests. Please run
 # `python test/generate_parse_fixture_yml.py`  to generate them after adding or
 # altering SQL files.
-_hash: fe1d8471b24961aea092895d11ae6a6bfc12fdfe321c7b29caf58bbbd84f8312
+_hash: a93c7bb9defb272cbc85dcc80feea185c38a95cdfa7c272f4bdbee43d6ac5f61
 file:
   statement:
     create_function_statement:
@@ -12,7 +12,7 @@ file:
     - keyword: FUNCTION
     - function_name:
         function_name_identifier: qs
-    - base:
+    - function_parameter_list:
         bracketed:
           start_bracket: (
           parameter: y
@@ -31,7 +31,7 @@ file:
             data_type_identifier: INT64
           end_angle_bracket: '>'
         end_angle_bracket: '>'
-    - base:
+    - function_definition:
       - keyword: LANGUAGE
       - parameter: js
       - keyword: AS

test/fixtures/dialects/bigquery/create_js_function_simple.yml

@@ -3,22 +3,22 @@
 # computed by SQLFluff when running the tests. Please run
 # `python test/generate_parse_fixture_yml.py`  to generate them after adding or
 # altering SQL files.
-_hash: 96f88fcc9be589d88561ea790a1deb4ed794c11d9f0279ece2eedcd28cdc7dcd
+_hash: 72b8e6ab4471c0c42038231a70bd81ba9ec1773a23875d126a643e655e7c0eec
 file:
   statement:
     create_function_statement:
     - keyword: CREATE
     - keyword: FUNCTION
     - function_name:
         function_name_identifier: qs
-    - base:
+    - function_parameter_list:
         bracketed:
           start_bracket: (
           parameter: y
           data_type:
             data_type_identifier: STRING
           end_bracket: )
-    - base:
+    - function_definition:
       - keyword: LANGUAGE
       - parameter: js
       - keyword: AS