chore(ios): Bump to Xcode 15.1 and Ruby 3.2.2 [UI-5184] #477
Conversation
robmaceachern
force-pushed
the
robmaceachern/xcode-15-bump
branch
2 times, most recently
from
a00a5c7
to
2b21739
Compare
| # Read the current Ruby version from the .ruby-version file | ||
| ruby Bundler.read_file(Bundler.root.join('.ruby-version')).strip | ||
|
|
There was a problem hiding this comment.
Not strictly necessary but should help ensure that we aren't accidentally using the wrong Ruby version when bumping gems (a mistake I made when bumping the gems in this PR!)
There was a problem hiding this comment.
Oh, interesting, did you find this somewhere?
There was a problem hiding this comment.
Yeah this was a bit of a rabbit hole. It went something like:
- Ruby version in gemfile
- https://andycroll.com/ruby/read-ruby-version-in-your-gemfile/
- Then when I discovered that that broke
bundle installoutside of the root dir, I discoveredruby file: '.ruby-version'exists: Addfileoption torubymethod in Gemfile rubygems/rubygems#6876 and fix Resolve ruby version file relative to bundle root rubygems/rubygems#6892 - Rather than force everyone to update their Bundler to support the feature, I looked up the source and pulled out the one liner.
Snapshots from CI Disabled the `test_nestedBoxes` test
robmaceachern
force-pushed
the
robmaceachern/xcode-15-bump
branch
from
bedb9c3
to
d9327a5
Compare
robmaceachern
force-pushed
the
robmaceachern/xcode-15-bump
branch
from
d7bb27a
to
699897a
Compare
robmaceachern
changed the title
There was a problem hiding this comment.
Calling out this and the following image for superficial iOS 15 changes.
There was a problem hiding this comment.
Calling out this and the following image for superficial iOS 15 changes.
| @@ -119,9 +119,6 @@ class AttributedTextTests: XCTestCase { | |||
| var text = AttributedText("some emoji: 😵💫👨👩👧👦🏃🏽 and some hiragana: あいうえお and some katakana: アイウエオカキクケコ") | |||
| text.color = .blue | |||
|
|
|||
| let partialEmoji = text.range(of: "😵")! | |||
There was a problem hiding this comment.
This was failing on iOS 17 tests and tbh I don't know if it really makes sense so I've removed it.
There was a problem hiding this comment.
I want to say that we copied these from some tests in the swift repo but I can't find the originals.
There was a problem hiding this comment.
I know there's one other kind of unusual emoji range test I've run into here: https://github.com/squareup/market/pull/7112/files#r1341394435
| # Read the current Ruby version from the .ruby-version file | ||
| ruby Bundler.read_file(Bundler.root.join('.ruby-version')).strip | ||
|
|
There was a problem hiding this comment.
Oh, interesting, did you find this somewhere?
| @@ -119,9 +119,6 @@ class AttributedTextTests: XCTestCase { | |||
| var text = AttributedText("some emoji: 😵💫👨👩👧👦🏃🏽 and some hiragana: あいうえお and some katakana: アイウエオカキクケコ") | |||
| text.color = .blue | |||
|
|
|||
| let partialEmoji = text.range(of: "😵")! | |||
There was a problem hiding this comment.
I want to say that we copied these from some tests in the swift repo but I can't find the originals.
…ller * origin/main: (62 commits) AccessibilityBlocker aggressively blocking. (#483) Bumping version to 3.0.0 (#482) Allow for customization of the preview name (#478) Update CHANGELOG for AttributedLabel fixes (#480) Fix link detection for stretched labels (#476) chore: Updated minimum deployment target from iOS 14 to iOS 15 [UI-5185] (#479) chore(ios): Bump to Xcode 15.1 and Ruby 3.2.2 [UI-5184] (#477) AXCustomContent Support (#471) Bumping versions to 2.2.0 (#470) Update concatenation logic and unit tests update changelog never cache subelements optionally do not cache subelements Feature: add TintAdjustmentMode, modifiers, and tests Add to CHANGELOG Add tintAdjustmentMode to Image Bumping versions to 2.1.0 (#466) Resolved a Swift 5.9 compilation warning (#465) Update KeyboardObserver (#463) Bump activesupport from 7.0.4.3 to 7.0.7.2 ...
For UI-5184
Updated CI to use M1 machines, Xcode 15.1, and Ruby 3.2.2.
Added iOS 17 snapshot images.
Removed iOS 14 snapshot images (deployment target change coming in followup PR)
Bump Swift version to 5.9.
Update Ruby gems.
iOS 14.5 SDK removed from test matrix.
iOS 15.0 SDK updated to iOS 15.4 in test matrix.
iOS 17.2 SDK added to test matrix.
Update repo required checks: include iOS 17 tests, remove iOS 14, and update to iOS 15.4.