AccessibilityBlocker aggressively blocking. #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… isBlocking is false
kyleve
reviewed
Mar 5, 2024
| @@ -33,7 +33,7 @@ public struct AccessibilityBlocker: Element { | |||
|
|
|||
| public func backingViewDescription(with context: ViewDescriptionContext) -> ViewDescription? { | |||
| UIView.describe { config in | |||
| config[\.isAccessibilityElement] = !isBlocking | |||
| config[\.isAccessibilityElement] = false | |||
There was a problem hiding this comment.
Ahh, since this is just a container, right?
kyleve
approved these changes
Mar 5, 2024
RoyalPineapple
commented
Mar 5, 2024
| @@ -33,7 +33,7 @@ public struct AccessibilityBlocker: Element { | |||
|
|
|||
| public func backingViewDescription(with context: ViewDescriptionContext) -> ViewDescription? { | |||
| UIView.describe { config in | |||
| config[\.isAccessibilityElement] = !isBlocking | |||
There was a problem hiding this comment.
This UIView should never be an accessibilityElement because it's always wrapping another element.
if this gets set to true (when isBlocking is false) it also blocks the accessibility because voiceover never asks for its children.
kyleve
added a commit
that referenced
this pull request
Mar 16, 2024
…ller * origin/main: (62 commits) AccessibilityBlocker aggressively blocking. (#483) Bumping version to 3.0.0 (#482) Allow for customization of the preview name (#478) Update CHANGELOG for AttributedLabel fixes (#480) Fix link detection for stretched labels (#476) chore: Updated minimum deployment target from iOS 14 to iOS 15 [UI-5185] (#479) chore(ios): Bump to Xcode 15.1 and Ruby 3.2.2 [UI-5184] (#477) AXCustomContent Support (#471) Bumping versions to 2.2.0 (#470) Update concatenation logic and unit tests update changelog never cache subelements optionally do not cache subelements Feature: add TintAdjustmentMode, modifiers, and tests Add to CHANGELOG Add tintAdjustmentMode to Image Bumping versions to 2.1.0 (#466) Resolved a Swift 5.9 compilation warning (#465) Update KeyboardObserver (#463) Bump activesupport from 7.0.4.3 to 7.0.7.2 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug where
AccessibilityBlockerwould block accessibility whenisBlockingisfalse