Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AccessibilityBlocker aggressively blocking. #483

Merged
merged 1 commit into from
Mar 5, 2024
Merged

AccessibilityBlocker aggressively blocking. #483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion BlueprintUICommonControls/Sources/AccessibilityBlocker.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public struct AccessibilityBlocker: Element {

public func backingViewDescription(with context: ViewDescriptionContext) -> ViewDescription? {
UIView.describe { config in
config[\.isAccessibilityElement] = !isBlocking
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This UIView should never be an accessibilityElement because it's always wrapping another element.
if this gets set to true (when isBlocking is false) it also blocks the accessibility because voiceover never asks for its children.

config[\.isAccessibilityElement] = false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, since this is just a container, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exactly

config[\.accessibilityElementsHidden] = isBlocking
}
}
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Main]

### Fixed
- Fixed a bug where `AccessibilityBlocker` would block accessibility when `isBlocking` is `false`

### Added

Expand Down