This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
Fix Assisted Factory binding location. #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianv1
force-pushed
the
sebastianv1/fix-factory-error
branch
from
652cb22
to
dca805e
Compare
The source location for assisted factory bindings was being set at the `file`, `line`, and `function` within the `AssistedInjectionArities.swift` file, which makes the debug information incorrect for errors such as `MissingProvider`. This change should correctly place the source location info at the site of the binding for assisted factories.
sebastianv1
force-pushed
the
sebastianv1/fix-factory-error
branch
from
dca805e
to
e987d25
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source location for assisted factory bindings was being set at the
file,line, andfunctionwithin theAssistedInjectionArities.swiftfile, which makes the debug information incorrect for errors such asMissingProvider. This change should correctly place the source location info at the site of the binding for assisted factories.