Supplementary Tracking Fixes #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleve
commented
Sep 29, 2022
kyleve
commented
Jul 5, 2023
* origin/main: (88 commits) Prep 11.0 release Paged list layouts now support using bounds, instead of itemInsets. Prep 10.3.1 release Update CHANGELOG iOS 17.0b1 first responder changes Update docs Prep 10.3.0 Allow programmatically showing leading and trailing swipe actions Update docs Prepare 10.2.0 PR feedback updates Separated out OverlayDecorationView and UnderlayDecorationView Updated Changelog Added an underlay view to item cells Added read-only dynamic member lookup support to ListProperties (#484) Release 10.1.0 (#482) Bump Blueprint dependency to 2.0 Replace xcversion with xcodes Fix issue where first tap on a header with no pressed background would eat the tap Re-generate the documentation ...
* origin/main: Swipe Action Updates (#489)
kyleve
commented
Jul 12, 2023
Demo/Sources/Demos/Demo Screens/SupplementaryTestingViewController.swift
Show resolved
Hide resolved
kyleve
commented
Jul 12, 2023
| /// has already assigned us a new supplementary view. Make sure the one | ||
| /// we're being asked to remove is the one we know about, otherwise, do nothing. | ||
|
|
||
| guard view === visibleContainer else { |
There was a problem hiding this comment.
❇️ This is the specific, actual fix.
kyleve
commented
Jul 12, 2023
kyleve
changed the title
kyleve
commented
Sep 18, 2023
* origin/main: Release 13.0.0 (#504) Update KeyboardObserver (#499) CONV-1435: Gravity layout frame change fix - Before: Layout gravity doesn't take into account frame changes. For example, when the orientation changes the scroll position (relative to the bottom) changes - After: Layout gravity takes frame changes into account so the when the frame changes the scroll position relative to the bottom remains unchanged Release 12.0.0 (#501) CONV-1435: Add scroll indicator insets to customScrollViewInsets (#500) CONV-1435: Gravity layout - Adds a new Chat App demo and a new behavior called verticalLayoutGravity. When verticalLayoutGravity is set to bottom, scrolling works the way you would expect for a messaging app. expose onKeyboardFrameWillChange on ListProperties onKeyboardFrameWillChange: Improve CHANGELOG, DocC CONV-1435: Custom keyboard adjustment mode - Adds a .custom KeyboardAdjustmentMode to fully customize inset behavior remove contentOffset from isContentScrollable calculation, improve comment Add ListView#isContentScrollable property - Add this property to ListView. It will be used in conjunction with upcoming so-called gravity scrolling changes to workaround an animation issue with paging Update CI script to reference the `xcodesorg/made/xcodes` package for installing simulator runtimes. (#494)
n8chur
approved these changes
Sep 20, 2023
kyleve
added a commit
that referenced
this pull request
Nov 19, 2023
…rovements * origin/main: (123 commits) Update CHANGELOG.md (#508) Revert "Supplementary Tracking Fixes (#433)" Revert "Force layout before appear, to avoid animated updates (#505)" Force layout before appear, to avoid animated updates (#505) Update workaround versions (#506) Fix supplementary view + contained first responder reuse issue (#507) Supplementary Tracking Fixes (#433) Release 13.0.0 (#504) Update KeyboardObserver (#499) CONV-1435: Gravity layout frame change fix - Before: Layout gravity doesn't take into account frame changes. For example, when the orientation changes the scroll position (relative to the bottom) changes - After: Layout gravity takes frame changes into account so the when the frame changes the scroll position relative to the bottom remains unchanged Release 12.0.0 (#501) CONV-1435: Add scroll indicator insets to customScrollViewInsets (#500) CONV-1435: Gravity layout - Adds a new Chat App demo and a new behavior called verticalLayoutGravity. When verticalLayoutGravity is set to bottom, scrolling works the way you would expect for a messaging app. expose onKeyboardFrameWillChange on ListProperties onKeyboardFrameWillChange: Improve CHANGELOG, DocC CONV-1435: Custom keyboard adjustment mode - Adds a .custom KeyboardAdjustmentMode to fully customize inset behavior remove contentOffset from isContentScrollable calculation, improve comment Add ListView#isContentScrollable property - Add this property to ListView. It will be used in conjunction with upcoming so-called gravity scrolling changes to workaround an animation issue with paging Update CI script to reference the `xcodesorg/made/xcodes` package for installing simulator runtimes. (#494) Swipe Action Updates (#489) ...
kyleve
added a commit
that referenced
this pull request
Dec 8, 2023
…rements * origin/main: Update CHANGELOG.md Allow other panning to work on other cells while another is open Remove `isTouchWithinSwipeActionView` Update swipe actions to more closely match iOS behavior Update CHANGELOG.md Release 13.1.0 Only return existing view if there is a contained first responder Self code review Fixed an issue where a crash would occur when applying an external update to list content while a live reorder event was occurring. Remove override of performBatchUpdates, it causes warnings for consumers Update CHANGELOG.md (#508) Revert "Supplementary Tracking Fixes (#433)" Revert "Force layout before appear, to avoid animated updates (#505)"
1 task
kyleve
added a commit
that referenced
this pull request
Aug 1, 2024
* origin/main: Prepare 14.3.0 (#540) Custom Update Animations (#539) Update version to 14.2.0 Prepare 14.2.0 release, which contains a Blueprint update Bumping versions to 14.1.0 (#535) reorder control now proxies accessibility into a seperate element (#533) Prepare 14.0.3 Fix a crash that could occur during cell reuse if a list contained different types of headers. The wrong ObjectIdentifier was being compared and stored. Get a repro for the reordering crash reported in #market-ios chore: Generated documentation now uses a static copyright notice to avoid noisy diffs (#530) Bumping versions to 15.0.2 fix: Fix tap gesture swallowing touches in swipe actions view Bump to 14.0.1 Fix SPM Blueprint dependency Release 14.0.0, update BlueprintUI to 3.0.0 (#525) chore: iOS 15 deployment target bump [UI-5187] (#524) chore: Bump CI to Xcode 15.1. Bump gems. [UI-5186] (#523) fix: don't cancel touches in view for tap gesture recognizer Revert weak change Revert "Revert "Supplementary Tracking Fixes (#433)""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where during supplementary updates, views weren't associated properly. This resulted in some updates, like light to dark mode changes being skipped in supplementary views.
https://block.atlassian.net/browse/UI-4473
Checklist
Please do the following before merging:
Mainsection.