chore: Bump CI to Xcode 15.1. Bump gems. [UI-5186] #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create run_ios17_tests.sh
Update .ruby-version
Error was: "cannot load underlying module for 'UIKit'"
robmaceachern
commented
Feb 12, 2024
|
|
||
| - name: Checkout repository | ||
| uses: actions/checkout@v1 | ||
| run: xcodebuild -scheme "Listable-Package" -destination "platform=iOS Simulator,OS=17.2" -sdk iphonesimulator build |
There was a problem hiding this comment.
I was experiencing errors locally and on CI using the old build command on Xcode 15 so I migrated to xcodebuild and it seems to be working as expected.
robmaceachern
commented
Feb 12, 2024
Comment on lines
+61
to
+62
| - name: Setup Ruby | ||
| uses: ruby/setup-ruby@v1 |
There was a problem hiding this comment.
Migrated to the setup-ruby action which simplifies some of the Bundler stuff (and ensures we're using the ruby version specified in .ruby-version.
robmaceachern
commented
Feb 12, 2024
Comment on lines
+90
to
+92
| - name: Build & Test | ||
| run: | | ||
| xcodebuild -workspace Demo/Demo.xcworkspace -scheme "Demo" -destination "platform=iOS Simulator,OS=${{ matrix.sdk }},name=${{ matrix.simulator_name }}" build test |
There was a problem hiding this comment.
Rather than per-iOS-version test scripts, we just have a single parameterized xcodebuild command.
robmaceachern
commented
Feb 12, 2024
| @@ -45,7 +45,7 @@ let package = Package( | |||
| .process("Resources"), | |||
| ] | |||
| ), | |||
| .testTarget( | |||
| .target( | |||
There was a problem hiding this comment.
Xcode was complaining about the SnapshotTests and ListableUITests targets depending on a test target, so I just made it a target 🤷🏽
robmaceachern
commented
Feb 12, 2024
There was a problem hiding this comment.
I didn't see this referenced anywhere so I killed it, but if it's part of your workflow I can re-create it.
kyleve
approved these changes
Feb 12, 2024
|
Updated the branch protection rules, feel free to merge whenever! |
kyleve
added a commit
that referenced
this pull request
Aug 1, 2024
* origin/main: Prepare 14.3.0 (#540) Custom Update Animations (#539) Update version to 14.2.0 Prepare 14.2.0 release, which contains a Blueprint update Bumping versions to 14.1.0 (#535) reorder control now proxies accessibility into a seperate element (#533) Prepare 14.0.3 Fix a crash that could occur during cell reuse if a list contained different types of headers. The wrong ObjectIdentifier was being compared and stored. Get a repro for the reordering crash reported in #market-ios chore: Generated documentation now uses a static copyright notice to avoid noisy diffs (#530) Bumping versions to 15.0.2 fix: Fix tap gesture swallowing touches in swipe actions view Bump to 14.0.1 Fix SPM Blueprint dependency Release 14.0.0, update BlueprintUI to 3.0.0 (#525) chore: iOS 15 deployment target bump [UI-5187] (#524) chore: Bump CI to Xcode 15.1. Bump gems. [UI-5186] (#523) fix: don't cancel touches in view for tap gesture recognizer Revert weak change Revert "Revert "Supplementary Tracking Fixes (#433)""
kyleve
added a commit
that referenced
this pull request
Aug 6, 2024
…rovements * origin/main: (33 commits) Prepare 14.3.0 (#540) Custom Update Animations (#539) Update version to 14.2.0 Prepare 14.2.0 release, which contains a Blueprint update Bumping versions to 14.1.0 (#535) reorder control now proxies accessibility into a seperate element (#533) Prepare 14.0.3 Fix a crash that could occur during cell reuse if a list contained different types of headers. The wrong ObjectIdentifier was being compared and stored. Get a repro for the reordering crash reported in #market-ios chore: Generated documentation now uses a static copyright notice to avoid noisy diffs (#530) Bumping versions to 15.0.2 fix: Fix tap gesture swallowing touches in swipe actions view Bump to 14.0.1 Fix SPM Blueprint dependency Release 14.0.0, update BlueprintUI to 3.0.0 (#525) chore: iOS 15 deployment target bump [UI-5187] (#524) chore: Bump CI to Xcode 15.1. Bump gems. [UI-5186] (#523) fix: don't cancel touches in view for tap gesture recognizer fix: don't cancel touches in view for tap gesture recognizer Revert weak change ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For UI-5186
Checklist
Please do the following before merging:
Mainsection.