You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
I have found a few cases were we have not been applying changes to either v2 or master branch (current v3 development). To make things clearer, I propose we only create PRs targeting master and then cherry-pick to v2 (when applicable):
If PR for v3 also makes sense for v2 (say a bug-fix or a backward-compatible feature), let's label the PR V2-Cherry-Pick (or something similar), so we know a cherry-pick should be made onto v2 (and a person merging should create a separate commit with cherry pick).
If PR is only to fix v2, then PR should be labeled accordingly, e.g. V2-Only.
Here's the list of (potential) discrepancies I have found to date:
Cool, I have created the labels and opened #291 and #292 to back-port and port-forward the missing changes. The remaining PR (#261) is being tracked already in #257.
I have found a few cases were we have not been applying changes to either v2 or master branch (current v3 development). To make things clearer, I propose we only create PRs targeting master and then cherry-pick to v2 (when applicable):
V2-Cherry-Pick
(or something similar), so we know a cherry-pick should be made onto v2 (and a person merging should create a separate commit with cherry pick).V2-Only
.Here's the list of (potential) discrepancies I have found to date:
master-only PRs:
v2-only PRs:
The text was updated successfully, but these errors were encountered: