Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Add opaque key encryption and opaque key decryption #257

Closed
wants to merge 10 commits into from

Conversation

garrickb
Copy link

Following the existing OpaqueSigner and OpaqueVerifier, I have added an OpaqueKeyEncrypter and OpaqueKeyDecrypter. This adds the ability to provide an opaque encrypter and decrypter. The motivation behind this is to support using a KMS to encrypt/decrypt CEKs.

Related issue: #256

@CLAassistant
Copy link

CLAassistant commented Sep 11, 2019

CLA assistant check
All committers have signed the CLA.

@garrickb
Copy link
Author

@csstaub any idea why GolangCI can't analyze?

@csstaub
Copy link
Collaborator

csstaub commented Sep 15, 2019

Not sure, but I will take a look. This looks like a good v2 addition btw before I refactor this whole code for v3 to make this type of thing easier.

@garrickb
Copy link
Author

Not sure, but I will take a look. This looks like a good v2 addition btw before I refactor this whole code for v3 to make this type of thing easier.

Is there any additional work for me to get this change in v2? Do I need to create a PR on the v2 branch?

@csstaub
Copy link
Collaborator

csstaub commented Sep 17, 2019

I can merge it into the v2 branch and tag it, just haven't gotten around to looking at this in detail yet.

@garrickb
Copy link
Author

Do you know when you'd be able to take a look over this, @csstaub ?

@csstaub
Copy link
Collaborator

csstaub commented Sep 19, 2019

I'll work on it this weekend

@csstaub
Copy link
Collaborator

csstaub commented Sep 23, 2019

LGTM, thank you @garrickb. I rebased onto v2 branch in #261. Note for v3 I want to eventually land #248, which should allow for something similar by getting rid of reflection and exposing an interface for decryption/encryption keys.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants