This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 278
Add opaque key encryption and opaque key decryption #257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@csstaub any idea why GolangCI can't analyze? |
Not sure, but I will take a look. This looks like a good v2 addition btw before I refactor this whole code for v3 to make this type of thing easier. |
Is there any additional work for me to get this change in v2? Do I need to create a PR on the |
I can merge it into the v2 branch and tag it, just haven't gotten around to looking at this in detail yet. |
Do you know when you'd be able to take a look over this, @csstaub ? |
I'll work on it this weekend |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the existing
OpaqueSigner
andOpaqueVerifier
, I have added anOpaqueKeyEncrypter
andOpaqueKeyDecrypter
. This adds the ability to provide an opaque encrypter and decrypter. The motivation behind this is to support using a KMS to encrypt/decrypt CEKs.Related issue: #256