Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Cherry-pick v2 PRs #292

Merged
merged 4 commits into from
Mar 8, 2020
Merged

Cherry-pick v2 PRs #292

merged 4 commits into from
Mar 8, 2020

Conversation

mbyczkowski
Copy link
Contributor

I found that a number of PRs, that were applicable to v3, had only been merged to v2 -- this issue has been documented in #290.

This PR brings the following changes to v3:

@mbyczkowski mbyczkowski requested a review from csstaub March 8, 2020 03:00
encoding.go Show resolved Hide resolved
encoding.go Show resolved Hide resolved
signing_test.go Show resolved Hide resolved
signing_test.go Outdated Show resolved Hide resolved
})
assert.Nil(t, err)
// Payload should be b64 encoded
assert.Len(t, data, len(b64TrueHeader.base64())+len(encodedPayload)+1)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mnd: Magic number: 1, in detected (from gomnd)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably disable gomnd in test files

})
assert.Nil(t, err)
// Payload should *not* be b64 encoded
assert.Len(t, data, len(b64FalseHeader.base64())+len(payload)+1)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mnd: Magic number: 1, in detected (from gomnd)

@mbyczkowski mbyczkowski merged commit 7bd4791 into master Mar 8, 2020
@mbyczkowski mbyczkowski deleted the mbyczkowski/v3-cherry-picks branch March 8, 2020 18:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants