pkg/: FEATURE: support allowed IPs outside a cluster #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squat
reviewed
May 27, 2021
squat
reviewed
May 27, 2021
squat
reviewed
May 27, 2021
squat
reviewed
May 27, 2021
squat
reviewed
May 27, 2021
squat
reviewed
May 27, 2021
squat
reviewed
May 27, 2021
|
Another question is if we should do any checks. I think you can mess up all networking if you specify a wireguard ip or something out of the pod or service cidr as an allowed location ip? |
leonnicolas
force-pushed
the
location_allowed_ips
branch
from
3659de4 to
af32cc7
Compare
|
Looks amazing! Should we document this in this PR? Or in a follow up PR? i.e. add it to this table: https://github.com/squat/kilo/blob/main/docs/annotations.md#annotations |
leonnicolas
force-pushed
the
location_allowed_ips
branch
from
2228c37 to
efddd2c
Compare
Users can specify IPs with the annotation "allowed-location-ips". It makes no difference which node of a location is annotated. The IP should be routable from the particular location, e.g. a printer in the same LAN. This way these IPs become routable from other location. Signed-off-by: leonnicolas <leonloechner@gmx.de> Co-authored-by: Lucas Servén Marín <lserven@gmail.com>
Signed-off-by: leonnicolas <leonloechner@gmx.de>
leonnicolas
force-pushed
the
location_allowed_ips
branch
from
efddd2c to
0255214
Compare
squat
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can specify IPs with the annotation "allowed-location-ips".
It makes no difference which node of a location is annotated.
The IP should be routable from the particular location, e.g. a printer in
the same LAN.
This way these IPs become routable from other location.
Signed-off-by: leonnicolas leonloechner@gmx.de