Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Squiz.WhiteSpace.OperatorSpacing false positive on unary minus after comment #1605

Closed
umherirrender opened this issue Aug 11, 2017 · 2 comments
Closed

Squiz.WhiteSpace.OperatorSpacing false positive on unary minus after comment #1605

umherirrender opened this issue Aug 11, 2017 · 2 comments
Labels
Type: bug

Comments

@umherirrender
Copy link

In the mediawiki/core code the Squiz.WhiteSpace.OperatorSpacing was added, but it reports (and fixed) a false positive for an unary minus, which has a comment before it, see [1]

| ERROR | [x] Expected 1 space after "-"; 0 found | | (Squiz.WhiteSpace.OperatorSpacing.NoSpaceAfter)

Maybe it is possible to allow this situation.

[1] https://gerrit.wikimedia.org/r/#/c/371474/1/includes/Sanitizer.php
@WMDE-Fisch
Copy link

again this is on version 3.0.2

@jrfnl jrfnl mentioned this issue Aug 13, 2017
Merged
@jrfnl
Copy link
Contributor

jrfnl commented Aug 13, 2017

@umherirrender @WMDE-Fisch I believe PR #1608 should fix this for you ;-)

gsherwood added a commit that referenced this issue Aug 15, 2017
@gsherwood
Changelog for #1605 (ref #1608)
241d5e1
@dependencies dependencies bot mentioned this issue Aug 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gsherwood @jrfnl @umherirrender @WMDE-Fisch