Squiz/OperatorSpacing: fix false positive on unary minus after comment. #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes (just and only) the code block which determines whether a minus sign is used as an operator or a unary, to use `$emptyTokens` instead of `T_WHITESPACE` for improved accuracy. Includes unit tests. Fixes 1605
jrfnl
force-pushed
the
feature/issue-1605-squiz-operator-spacing-unary
branch
from
70bbbd2
to
c0564f5
Compare
gsherwood
added a commit
that referenced
this pull request
Aug 15, 2017
|
Thanks a lot. |
|
You're very welcome ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes (just and only) the code block which determines whether a minus sign is used as an operator or a unary, to use
$emptyTokensinstead ofT_WHITESPACEfor improved accuracy.Includes unit tests.
Fixes #1605