-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Go modules #219
Introduce Go modules #219
Conversation
Although these are not sorted out yet, early feedback is very appreciated! |
33a58ac
to
5485aa2
Compare
The only failure on
which does not seem relevant. One last thing left is - fix a CGO profiles on CI that seems to fail due to what seems to be some compiler/linker version missmatch
|
It looks relevant to me—the error is from a module-aware build, not being able to identify the main module. It is probably a configuration issue rather than a code bug, though. This is typical of what you get if either (a) you build inside |
CI is going to be fixed on master in separate PR #221. |
Needs to be rebased on master, after #222 lands:
|
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
As discussed, consensus is that Looking into code generator test fail with \w oniguruma:
|
CI fails due to #225 that should be investigated and fixed in a separate profile. This is ready to be merged as soon as |
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
- update go.mod \w v2 - update all import paths Signed-off-by: Alexander Bezzubov <bzz@apache.org>
This is ready to be merged now - v2 was added in 6a5f37e CI will be taken care of under #225 before v2.0.0 release |
This fixes #170 by adding Modules support.
go.sum
andgo.mod
addedgopkg.in
go get
go test all
failure 1heuristics.go
go test all
failure 2TestCrashDumpsAllThreads
CI: fix cgo profiles for newer go compiler versions/v2